Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xcode 10] Build crashes #133

Closed
alexktzk opened this issue Mar 21, 2020 · 7 comments · Fixed by #151
Closed

[xcode 10] Build crashes #133

alexktzk opened this issue Mar 21, 2020 · 7 comments · Fixed by #151
Assignees

Comments

@alexktzk
Copy link

alexktzk commented Mar 21, 2020

Bug

Build crashes on IOS, because labelColor variable does not exist.

Actual error message:

.../node_modules/@react-native-community/datetimepicker/ios/RNDateTimePickerManager.m:51:33: 
error: no known class method for selector 'labelColor'
        defaultColor = [UIColor labelColor];

Environment info

Library version: 2.3.0
IOS: 13.2.2

@alexktzk alexktzk changed the title [IOS 13+] Build crushes [IOS 13+] Build crashes Mar 21, 2020
@deborahhellen
Copy link

+1 also seeing the same issue.

@alexktzk
Copy link
Author

@ShenAizhen you're right, the problem appeared with this commit.

I used the previous version for now. Just in case, the version in package.json must be without ^, because otherwise it actually installs 2.3.0 when you run pod install

"@react-native-community/datetimepicker": "2.2.3",

not

"@react-native-community/datetimepicker": "^2.2.3",

@vonovak
Copy link
Member

vonovak commented Mar 23, 2020

hello, what xcode version are you folks using? Thanks

@omerman
Copy link

omerman commented Mar 23, 2020

Happens to me as well.

@vonovak
Xcode 10.2.1
Build version 10E1001

@vonovak
Copy link
Member

vonovak commented Mar 23, 2020

upgrading to xcode 11 should fix this I think

@luancurti luancurti self-assigned this Apr 10, 2020
@luancurti luancurti added the bug Something isn't working label Apr 10, 2020
@vonovak
Copy link
Member

vonovak commented Apr 11, 2020

hello, if someone needs to support xcode 10, please open a PR that fixes the compilation in xcode 10. Maintainers will not be adding that support because we plan to fix more pressing issues, thank you.

@vonovak vonovak removed the bug Something isn't working label Apr 11, 2020
@react-native-datetimepicker react-native-datetimepicker locked and limited conversation to collaborators Apr 11, 2020
@vonovak vonovak changed the title [IOS 13+] Build crashes [xcode 10] Build crashes Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants
@vonovak @deborahhellen @omerman @luancurti @alexktzk and others