Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembling events in the meaningful format #15

Closed
saphal1998 opened this issue Jun 30, 2020 · 4 comments
Closed

Assembling events in the meaningful format #15

saphal1998 opened this issue Jun 30, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed priority-3 question Further information is requested
Projects
Hermes Profile Transformer

Comments

@saphal1998
Copy link
Collaborator

The idea is to isolate similar events and assign phases to them after reviewing these similar events
@saphal1998 saphal1998 created this issue from a note in Hermes Profile Transformer (To do) Jun 30, 2020
@saphal1998 saphal1998 moved this from To do to In progress in Hermes Profile Transformer Jun 30, 2020
@saphal1998 saphal1998 mentioned this issue Jun 30, 2020
Closed
@saphal1998 saphal1998 linked a pull request Jun 30, 2020 that will close this issue
Store all the sample events in a Graph structure #16
Closed
@saphal1998 saphal1998 added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Jul 1, 2020
@saphal1998
Copy link
Collaborator Author

Edit: Convert all events to complete events

@saphal1998
Copy link
Collaborator Author

saphal1998 commented Jul 8, 2020 •
edited

#18 #19 #14

  • Call Graph needs to debugged as all events aren't showing up, particularly App.js
  • Check if right structure is formed at all instances of time, Create a function call stack #19 helps with this
  • Fix duration of events (TBD)

@saphal1998
Copy link
Collaborator Author

Looking into conversion of Hermes Profiler into Profile Chunks so that it can directly be passed to the Chrome Dev Tools using the code in Lighthouse

@saphal1998
Copy link
Collaborator Author

This experiment has proved to be a success as we do obtain a Profile which looks similar to the result obtained by Facebook's internal tools

Hermes Profile Transformer automation moved this from In progress to Done Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed priority-3 question Further information is requested
Projects
No open projects
Hermes Profile Transformer
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store all the sample events in a Graph structure react-native-community/hermes-profile-transformer
2 participants
@saphal1998 @jessieAnhNguyen