Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Call Graph #18

Closed
3 tasks
saphal1998 opened this issue Jul 8, 2020 · 2 comments
Closed
3 tasks

Fix Call Graph #18

saphal1998 opened this issue Jul 8, 2020 · 2 comments
Labels
In progress priority-1 To do
Projects
Hermes Profile Transformer

Comments

@saphal1998
Copy link
Collaborator

  • Investigate why stackFrames (particularly stackFrames with name App.js) don't show up
  • Fix the convertToChromeSample method
  • Fix the setNodePhase method
@saphal1998 saphal1998 created this issue from a note in Hermes Profile Transformer (To do) Jul 8, 2020
@saphal1998 saphal1998 moved this from To do to In progress in Hermes Profile Transformer Jul 8, 2020
@saphal1998 saphal1998 mentioned this issue Jul 8, 2020
Closed
@saphal1998
Copy link
Collaborator Author

All data is ported over to the CallGraph DS 🍾. No need to rely on the hermes_sample.profile file anymore!

@saphal1998
Copy link
Collaborator Author

We can abandon the call graph approach in favour of the Profile Chunk format, as that can be readily processed by the Lighthouse Parser

Hermes Profile Transformer automation moved this from In progress to Done Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In progress priority-1 To do
Projects
No open projects
Hermes Profile Transformer
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saphal1998 @jessieAnhNguyen