Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add value to Coordinates when hide #120

Merged

Conversation

Gamal-Shaban
Copy link
Contributor

Summary

fix check in key board

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌
Web ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've created a snack to demonstrate the changes: LINK HERE

@vonovak
Copy link
Member

vonovak commented Mar 30, 2020

@Gamal-Shaban can you please run prettier with the correct config on this? thank you

@Gamal-Shaban
Copy link
Contributor Author

ok @vonovak

@Gamal-Shaban
Copy link
Contributor Author

done @vonovak

src/useKeyboard.ts Outdated Show resolved Hide resolved
@pvinis
Copy link
Member

pvinis commented Apr 6, 2020

Bumping this, otherwise, we could handle this in a few days. :)

@pvinis pvinis added release Create a release when this pr is merged patch Increment the patch version when merged labels Apr 13, 2020
Copy link
Member

@pvinis pvinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/useKeyboard.ts Outdated Show resolved Hide resolved
src/useKeyboard.ts Outdated Show resolved Hide resolved
@pvinis
Copy link
Member

pvinis commented Apr 13, 2020

you can just run yarn lint --fix and it should fix it for you. I made a suggestion with the correct one.

src/useKeyboard.ts Outdated Show resolved Hide resolved
@pvinis pvinis merged commit 378afac into react-native-community:master Apr 13, 2020
@Gamal-Shaban
Copy link
Contributor Author

you can just run yarn lint --fix and it should fix it for you. I made a suggestion with the correct one.

ok thanks

@pvinis
Copy link
Member

pvinis commented Apr 13, 2020

🚀 PR was released in v2.4.9 🚀

@pvinis pvinis added the released This issue/pull request has been released. label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants