Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useAppState tests #263

Merged
merged 1 commit into from Oct 18, 2021
Merged

Add useAppState tests #263

merged 1 commit into from Oct 18, 2021

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Oct 18, 2021

Summary

  • Add useAppState(...) tests
  • Move onChange callback inside useEffect hook (not need to create this function on each render, memory usage improvements)

Test Plan

yarn test

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅
Android ✅
Web ✅

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've created a snack to demonstrate the changes: LINK HERE

LinusU
LinusU approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

@LinusU LinusU added the skip-release Preserve the current version when merged label Oct 18, 2021
@LinusU LinusU merged commit ad27823 into react-native-community:master Oct 18, 2021
@retyui retyui deleted the add-use-app-state-test branch October 18, 2021 15:00
@pvinis
Copy link
Member

pvinis commented Oct 18, 2021

🚀 PR was released in v2.7.0 🚀

@pvinis pvinis added the released This issue/pull request has been released. label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@retyui @pvinis @LinusU