Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As facebook/react-native#24261, the community report my experimented builds still have crashes.
(fix __clear_cache commit as here Kudo@daf5700)
And they did mention that the no_jit version is crash free.
I am going to propose turning off JIT totally to make sure at least we have a stable JSC.
Will re-enable JIT if community feedback for a lot performance dropping and will try for next major WebKitWPE major release.
Disable JIT brings two benefits:
Measurement
Measurement methodology is pretty much like what I did in #105
For memory profiling, it is to execute
adb shell dumpsys meminfo com.javascriptcore.profiler
and compare TOTAL memory usage right after sunspider, jetstream, octane2, sixspeed benchmarks.Results
chromiumICUCommit:b34251f
i18n:false
chromiumICUCommit:b34251f
i18n:false
DFG_JIT:false
chromiumICUCommit:b34251f
i18n:false
DFG_JIT:false
JIT:false
https://docs.google.com/spreadsheets/d/1hqX3ai-NCpN_J6YQDTKnKNBctWnMFA6EyOdVhPvwUas/edit#gid=193471288