Deprecate AsyncStorage from React Native #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
added
enhancement
krizzu
force-pushed
the
support-community-extensions
branch
from
5be1149
to
0a331bd
Compare
tido64
approved these changes
Apr 9, 2019
krizzu
pushed a commit
that referenced
this pull request
Apr 10, 2019
# [1.3.0](v1.2.4...v1.3.0) (2019-04-10) ### Bug Fixes * Deprecate AsyncStorage from React Native ([#66](#66)) ([892afed](892afed)) * Prefer RNC's AsyncStorage over RN's. ([9fa8ab9](9fa8ab9)) * release config ([ab7848a](ab7848a)) * semantic-release configuration ([b3d1312](b3d1312)) ### Features * Jest mocks, testing guidelines ([485eba4](485eba4))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
From recent changes, we've moved back to add
LocalAsyncStoragenative module, which consequently fallbacks to deprecated Async Storage on RN Core.This change reverts this back and add new name, to be used by external storages.
Test Plan:
Green CI.