This repository has been archived by the owner on Jun 16, 2023. It is now read-only.
fix AutoFocus for Scanning on older Devices #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and device is scanning
sibelius
approved these changes
Jul 22, 2020
n1ru4l
pushed a commit
that referenced
this pull request
Jul 23, 2020
# [3.35.0](v3.34.0...v3.35.0) (2020-07-23) ### Features * **android:** use FOCUS_MODE_MACRO if FOCUS_MODE_CONTINOUS_PICTURE is not available and device is scanning ([#2912](#2912)) ([20c62fb](20c62fb))
|
🎉 This PR is included in version 3.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rfischer
pushed a commit
to rfischer/react-native-camera
that referenced
this pull request
Sep 17, 2020
* master: (30 commits) chore(release): 3.39.0 [skip ci] chore(deps): bump handlebars in /examples/advanced/advanced (react-native-camera#2968) feat(upgrade): upgrade deps (react-native-camera#2967) chore(deps): bump decompress from 4.2.0 to 4.2.1 in /website (react-native-camera#2962) chore(deps): bump @hapi/hoek in /examples/advanced/advanced (react-native-camera#2965) chore(release): 3.38.0 [skip ci] feat(windows): updates for RNW 0.63 (react-native-camera#2960) chore(release): 3.37.0 [skip ci] feat(ios): Reset cached exposure limits to avoid a crash. (react-native-camera#2948) fix(android): Fix camera parameters getting lost on setting focus. (react-native-camera#2946) feat(android): Document `pictureSize` and make sure Camera1 implementation uses it appropriately. (react-native-camera#2945) chore(release): 3.36.0 [skip ci] chore(deps): bump prismjs from 1.16.0 to 1.21.0 in /website (react-native-camera#2939) feat(windows): added barcode scanning support (react-native-camera#2930) chore(release): 3.35.0 [skip ci] feat(android): use FOCUS_MODE_MACRO if FOCUS_MODE_CONTINOUS_PICTURE is not available and device is scanning (react-native-camera#2912) chore(release): 3.34.0 [skip ci] feat(android): onBarCodeRead should also send raw photo bytes, fixed react-native-camera#2786 (react-native-camera#2923) chore(release): 3.33.0 [skip ci] feat(android): Added pause and resume recording (react-native-camera#2911) ...
sunil-dev7
added a commit
to sunil-dev7/react-native-camera
that referenced
this pull request
Jun 11, 2021
# [3.35.0](react-native-camera/react-native-camera@v3.34.0...v3.35.0) (2020-07-23) ### Features * **android:** use FOCUS_MODE_MACRO if FOCUS_MODE_CONTINOUS_PICTURE is not available and device is scanning ([#2912](react-native-camera/react-native-camera#2912)) ([20c62fb](react-native-camera/react-native-camera@20c62fb))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the autoFocus while Scanning for older Devices like the Samsung Xcover3.
Before the AutoFocus didn't focus on older Devices. Now it uses the FOCUS_MODE_MACRO when FOCUS_CONTINOUS_PICTURE isn't available and the device is scanning.
Test Plan
What's required for testing (prerequisites)?
An older device like the Samsung Galaxy XCover 3 which uses CameraApi1
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)