Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

Feature request: Add frame, audio and video encoding bit rate options #687

Closed
diegocouto opened this issue Apr 30, 2017 · 8 comments
Closed
Labels
Android Feature Request stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@diegocouto
Copy link

Hi there,

A 10s long video with 480p quality has a file size of more or less 3MB. For a lot of use cases, this is too large and this is why I think it would be great to allow some control over frame, audio and video encoding bit rates.

Android Support

I have updated RCTCameraModule.java with these hardcoded configs as an example, and we are getting files at least 3X smaller:

mMediaRecorder.setVideoFrameRate(20);
mMediaRecorder.setVideoEncodingBitRate(600 * 1000);
mMediaRecorder.setAudioEncodingBitRate(128 * 1000);

iOS Support

I'm not a iOS developer, so I wouldn't be able to help in here, but if someone would like to, I would be very happy to provide an Android implementation. 😉

@sibelius
Copy link
Collaborator

sibelius commented Jan 7, 2018

this 3 new props looks a good ideia

feel free to send a PR and we'll help you

@djleonskennedy

This comment has been minimized.

@IssueHuntBot
Copy link

@issuehuntfest has funded $40.00 to this issue. See it on IssueHunt

@n1ru4l
Copy link
Collaborator

n1ru4l commented Dec 19, 2018

@djleonskennedy Please feel free to send a pull request that implements these features.

@n1ru4l n1ru4l added the Android label Dec 19, 2018
@n1ru4l
Copy link
Collaborator

n1ru4l commented Jan 18, 2019

Bitrate is addressed here: #2055

@andrew-schenk
Copy link
Contributor

Resolved in v1.9.0

@stale
Copy link

stale bot commented May 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You may also mark this issue as a "discussion" and i will leave this open.

@stale stale bot added the stale There has been a lack of activity on this issue and it may be closed soon. label May 31, 2019
@stale
Copy link

stale bot commented Jun 8, 2019

Closing this issue after a prolonged period of inactivity. Fell free to reopen this issue, if this still affecting you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Feature Request stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

6 participants