chore: replace legacy circleci images #146
Conversation
chore: Switching from legacy circleci/node image to cimg/node images in linux_js executor
chore: Switching this repo's circleci config to use new cimg/node instead of legacy circleci/node
anthonymayer
changed the title
anthonymayer
changed the title
| @@ -21,7 +21,7 @@ jobs: | |||
| paths: . | |||
| publish: | |||
| docker: | |||
| - image: circleci/node:12 | |||
| - image: cimg/node:12 | |||
There was a problem hiding this comment.
Turns out that this broke our publishing pipeline. Could you fix it @anthonymayer
I believe it should be 12.22:
https://circleci.com/developer/images/image/cimg/node#image-tags
There was a problem hiding this comment.
@cortinico sorry about that, I thought they supported all the same tags. I'll fix it. I do wonder then if this needs to be considered a breaking change, since https://github.com/react-native-community/react-native-circleci-orb/pull/146/files#diff-0552beaefc6ae33d95cf39dcb9934ca462458a76f414573ac2b60c25926a8608R11 can take in versions which may no longer be compatible
There was a problem hiding this comment.
fix is here #147
There was a problem hiding this comment.
since #146 (files) can take in versions which may no longer be compatible
I think it might be the case yes. It's definitely worth noting somewhere in the release notes.
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
CircleCI deprecated the circleci/node image (see https://circleci.com/developer/images/image/cimg/node and https://circleci.com/docs/2.0/next-gen-migration-guide/). We're getting a warning on our CircleCI instance that there are going to be brownouts soon if you're still using these images, so I'm assuming it's good for everyone to get updated.