Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a shell check orb #159

Closed
wants to merge 2 commits into from

Conversation

szandany
Copy link

Hello,
My name is Tsvi and I am from the CircleCI team!
Added a shell check orb to your config.yml so that it will automatically find bugs and errors in your shell scripts with ShellCheck on every commit. Add this static analysis tool/orb to any CI/CD workflow and ShellCheck your scripts across your repository.

Added a shell check orb to automatically find bugs and errors in your shell scripts with ShellCheck on every commit. Add this static analysis tool/orb to any CI/CD workflow and ShellCheck your scripts across your repository.
@cortinico
Copy link
Member

My name is Tsvi and I am from the CircleCI team!

Can you please provide proof of this (i.e. being member of the CircleCI org or so)?

Added a shell check orb to your config.yml so that it will automatically find bugs and errors in your shell scripts with ShellCheck on every commit. Add this static analysis tool/orb to any CI/CD workflow and ShellCheck your scripts across your repository.

According to the official documentation (https://circleci.com/developer/orbs/orb/circleci/shellcheck) this is not correctly configured (as you need to invoke shellcheck/check)

@szandany
Copy link
Author

szandany commented Sep 7, 2022

Thanks for the notes, @cortinico
I committed another change to add the shellcheck to the workflow as a job. Please see the above commit.
I am going to send you an email verification via my circleci email domain as a proof that I am a member of the CircleCI team. :-)

@cortinico
Copy link
Member

Also I've realized we don't have any .sh file to lint so this step is probably useless

@szandany szandany closed this Sep 8, 2022
@szandany szandany deleted the patch-1 branch September 8, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants