Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Animated.Region #24 Fix on the AnimatedMarkers Example #1889

Merged
merged 2 commits into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@timotew
Copy link
Contributor

timotew commented Dec 14, 2017

Fix for 'Animated.Region undefined constructor' in recent react-native version.
Solved by using MapView.AnimatedRegion instead of Animated.Region

timotew added some commits Dec 14, 2017

Update for #24 Fix
Fix for 'Animated.Region undefined constructor' in recent react-native version. 
Solved by using MapView.AnimatedRegion instead of Animated.Region
Change Animated.Region #24 on AnimatedMarkers Example
Fix for 'Animated.Region undefined constructor' in recent react-native version.
Solved by using MapView.AnimatedRegion instead of Animated.Region
@timotew

This comment has been minimized.

Copy link
Contributor Author

timotew commented Dec 15, 2017

@christopherdro Hi there! How should we proceed on this PR?

@christopherdro christopherdro merged commit fe389e5 into react-native-community:master Dec 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@timotew timotew deleted the timotew:patch-1 branch Dec 31, 2017

xeoh added a commit to zigbang/react-native-maps that referenced this pull request Jan 8, 2018

Merge branch 'master' into zigbang
* master: (63 commits)
  Update MapOverlay.js (react-native-community#1927)
  Merge Ground Overlay Support (PR-1586) (react-native-community#1918)
  fixed polyline example
  default export is MapView (react-native-community#1904)
  Add gradient/multi-color polyline support for iOS (MapKit) (react-native-community#1911)
  Update issues template with no_template warning (react-native-community#1917)
  change name of project (react-native-community#1910)
  Updated installation guide with Xcode 8 possible error
  Manage Zoom Controls visibility on the map  (react-native-community#1906)
  Fixed minor styling issues in installation guide (react-native-community#1905)
  corrected default value to ``round`` (react-native-community#1898)
  Corrected doc text for Polyline (react-native-community#1899)
  Fixed onMapReady no longer getting called on iOS (react-native-community#1853)
  Fix example with animated markers (react-native-community#1840)
  Update installation.md (react-native-community#1892)
  Update for Animated.Region react-native-community#24 Fix on the AnimatedMarkers Example  (react-native-community#1889)
  v0.19.0
  Update examples-setup.md (react-native-community#1888)
  Fix main install docs (react-native-community#1887)
  Revert "Merge pull request #1 from react-community/master"
  ...

kdong007 pushed a commit to hetaoai/react-native-maps that referenced this pull request Jan 19, 2018

Update for Animated.Region react-native-community#24 Fix on the Anima…
…tedMarkers Example (react-native-community#1889)

* Update for react-native-community#24 Fix

Fix for 'Animated.Region undefined constructor' in recent react-native version. 
Solved by using MapView.AnimatedRegion instead of Animated.Region

* Change Animated.Region react-native-community#24 on AnimatedMarkers Example

Fix for 'Animated.Region undefined constructor' in recent react-native version.
Solved by using MapView.AnimatedRegion instead of Animated.Region
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.