Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify how to use Google Maps #2550

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
2 participants
@platonish
Copy link
Contributor

platonish commented Oct 15, 2018

Does any other open PR do the same thing?

No.

(please answer here)

What issue is this PR fixing?

Issue #2362

Installation docs do not mention that {PROVIDER_GOOGLE} needs to be added in order to make Google Maps work on iOS. This PR adds the required lines to make Google Maps work on iOS.

How did you test this PR?

This is an update to the documentation only.

@rborn

This comment has been minimized.

Copy link
Collaborator

rborn commented Oct 15, 2018

@platonish looks good, thanks a lot, could you please add some lines about this in https://github.com/react-community/react-native-maps/blob/master/docs/installation.md#enabling-google-maps-on-ios section too?
Thank you!

@rborn rborn added the waiting reply label Oct 15, 2018

Ashwin Nayar added some commits Oct 15, 2018

Ashwin Nayar Ashwin
Specify how to use Google Maps
Installation docs do not mention that `{PROVIDER_GOOGLE}` needs to be added in order to make Google Maps work.

@platonish platonish force-pushed the platonish:patch-1 branch from ca61406 to 0c93739 Oct 22, 2018

@rborn rborn merged commit 1844d46 into react-native-community:master Oct 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stan-sack added a commit to stan-sack/react-native-maps that referenced this pull request Nov 6, 2018

ryanbourneuk pushed a commit to 3sidedcube/react-native-maps that referenced this pull request Dec 10, 2018

Ryan Bourne
Merge remote-tracking branch 'upstream/master'
* upstream/master: (28 commits)
  Calculate bounding box from region (react-native-community#2615)
  [iOS GoogleMap] Fix animateCamera (react-native-community#2608)
  Fix type definition error (react-native-community#2607)
  [Android] Fix app crash in Android if building found but cannot getActiveLevelIndex (react-native-community#2598)
  Provide a camera system (react-native-community#2563)
  Get visible map bounding box (react-native-community#2571)
  [0.22.1] Release (react-native-community#2574)
  Move dev only deps to devDependencies. (react-native-community#2548)
  Specify how to use Google Maps (react-native-community#2550)
  r2507: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference #: remove marker: Attempt to invoke virtual method 'void com.google.android.gms.maps.model.setIcon(com.google.android.gms.maps.model.BitmapDescription)' on a null object reference (react-native-community#2555)
  update to clarify cacheEnabled is apple maps only
  [0.22.0] Release (react-native-community#2535)
  Fix for “The specified child already has a parent”
  Improve installation docs (react-native-community#2541)
  fix fitToSuppliedMarkers function (react-native-community#2524)
  Performance improvements for tracksViewChanges (react-native-community#2487)
  fix spelling mistakes
  Added flag to make sure that there has an Observer of view.
  hotfix PR react-native-community#2478
  Fix a peer dependencies warning
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.