Add "propagateSwipe" prop to allow scrolling inside modal #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmazzarolo
approved these changes
Feb 5, 2019
| @@ -196,7 +198,9 @@ class ReactNativeModal extends Component { | |||
| // work correctly even when the modal has touchable buttons. | |||
| // For reference: | |||
| // https://github.com/react-native-community/react-native-modal/pull/197 | |||
| return Math.abs(gestureState.dx) >= 4 || Math.abs(gestureState.dy) >= 4; | |||
There was a problem hiding this comment.
Mind adding a link to the PR here?
mmazzarolo
approved these changes
Feb 6, 2019
|
@cjroth published on |
|
Sad to say this does not work for me. I've got a vertical ScrollView inside a modal with I'm afraid I do not have the time to create a minimal reproducible example at the moment. |
|
😢 |
|
Yeah, sorry, I just mean close one, open the other, and link the two with a comment :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @mmazzarolo for figuring this out.
Fixes #236.