Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useNativeDriver not being used on the backdrop animation #304

Conversation

LuisRego
Copy link
Contributor

useNativeDriver is not being used on the backdrop animation. This can be an issue since some IOS devices does not handle the Native Driver correctly. IMO, the prop useNativeDriver should be used for both animations.

@mmazzarolo
Copy link
Member

mmazzarolo commented May 10, 2019

Thanks!

This can be an issue since some IOS devices does not handle the Native Driver correctly.

I wasn't aware of this.

That said, it makes sense.

@rewieer what do you think?
If it sounds good for you I'll merge it and publish a new major release (this might be a breaking change).

@ancyrweb
Copy link
Member

IMO, the prop useNativeDriver should be used for both animations.

Agree.

@rewieer what do you think?
If it sounds good for you I'll merge it and publish a new major release (this might be a breaking change).

Agree. Looks good to me.
Thanks you !

@mmazzarolo mmazzarolo merged commit 79668e5 into react-native-modal:master May 11, 2019
@mmazzarolo
Copy link
Member

Available in react-native-modal@11.0.0

@LuisRego
Copy link
Contributor Author

Available in react-native-modal@11.0.0

Great! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants