chore: update ios deployment target min to 9 (react-native min) #112
Conversation
|
Also note that we were just bitten (on react-native-share) with a build fail that was release-target only. And, I was also bitten recently on a build failure for tvOS only. Ugh. I mention this because you might want to add the matrix of build targets for your example to CircleCI - not just 1, but the full 2x2 of debug or release x iOS or tvOS. |
|
Thanks for the heads up about the build matrix. I'll take a look into that. |
|
when you init an example app they give you a hint on how to run the react-native CLI targeting other schemes, usually it's just adding |
## [3.2.1](v3.2.0...v3.2.1) (2019-06-01) ### Bug Fixes * Update iOS deployment target min to avoid a warning ([#112](#112) by [@mikehardy](https://github.com/mikehardy)) ([c05df9b](c05df9b))
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
This is a trivial patch - but react-native has an iOS minimum target of 9, and with this module set to 8 it generates a warning during the build
Insert ramble about broken windows theory with an add-on related to log spam here...
Note that all of this textual change was the result of simply opening the XCode project, going to the info area, and altering the minimum from 8 to 9 - it spiders out into a couple places at once and tries some i18n thing 🤷♂️
Test Plan