-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch(interface) [Android & iOS] #256
feat: fetch(interface) [Android & iOS] #256
Conversation
…aded the example project to RN 0.61.2
…aded the example project to RN 0.61.2
67f832c
to
e87181e
Compare
Thanks for submitting this. Sorry it's taken so long to get back to you on it. Now that the configuration change PR has been merged in, can you rebase your changes on the |
@matt-oakes feel free to review it whenever you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've made a few style changes to the native code to make them more idiomatic and fixed a small merge error on Android. Merging when the tests pass.
@Rapsssito Would you be interested in helping out with maintaining the library?
# [5.2.0](v5.1.0...v5.2.0) (2019-12-29) ### Features * Allow fetching details for a specific network interface ([#256](#256) by @Rapsssito) ([05e5fb7](05e5fb7))
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@matt-oakes, of course! However, I have zero experience with this types of libraries. I won't be taking part in big changes or issues until I feel confident. |
@matt-oakes, I'm sorry to bother you again, is the offer still standing? I have not received news since the message. |
Overview
Nowadays, most devices can handle multiple connections via different interfaces at the same time. This library automatically gets the current active connection given by the OS. However, there could be other connections going into the device.
With this feature, we maintain the current standard
NetInfo.fetch()
but adding the possibility to look for theNetInfoState
of a specific network interface.Implementation
Compatibility
Windows is not compatible. However, I could not test if my changes broke something there. Windows testing is necessary.
Related Issues
Fixes #211
Fixes #51
Fixes #52
Fixes #208
react-native-device-info/react-native-device-info#635