Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding conditions to exclude ssid from being used on tvOS #283

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

vdmtrv
Copy link
Contributor

@vdmtrv vdmtrv commented Jan 6, 2020

Overview

Preventing build failure by adding conditions to exclude ssid from being used on tvOS builds.

Copy link
Collaborator

@matt-oakes matt-oakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for sending this over. I need to add building for tvOS to the CI to check for issues like this as they're easy to miss.

@matt-oakes matt-oakes merged commit a0191e0 into react-native-netinfo:master Jan 6, 2020
react-native-community-bot pushed a commit that referenced this pull request Jan 6, 2020
## [5.3.2](v5.3.1...v5.3.2) (2020-01-06)

### Bug Fixes

* **tvOS:** Fixed a crash with tvOS builds caused by trying to use the ssid method ([#283](#283) by [@vdmtrv](https://github.com/vdmtrv)) ([a0191e0](a0191e0))
@react-native-community-bot
Copy link
Collaborator

🎉 This PR is included in version 5.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants