Fix: Properly report lost connection as 'none' on Android 24+ (#44) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for the PR! This all looks good. I'll merge and release now. |
react-native-community-bot
pushed a commit
that referenced
this pull request
Apr 26, 2019
|
🎉 This PR is included in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrejborstnik
pushed a commit
to ExodusMovement/react-native-netinfo
that referenced
this pull request
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the issue outlined in #44. With this change it is now possible to receive a "none" connection type and actually know when there is no connection available.
Test Plan
Tested on device with various combinations of airplane mode, wifi state, cellular radio, and VPN.
Closes #44.