feat: React-Native-MacOS Support #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naturalclar
reviewed
Aug 8, 2020
Naturalclar
reviewed
Aug 8, 2020
Naturalclar
reviewed
Aug 8, 2020
Naturalclar
requested changes
Aug 8, 2020
There was a problem hiding this comment.
@bralax Thank you so much!
There were some commented out sections left in the code. Could those be removed or have comments stating the reason for the comment out? Thanks 😄
|
Hi @Naturalclar That was my fault for leaving those in and I have no removed the comments. I was using the IOS implementation as a reference so a lot of that is that as I went I commented out code that did not apply to macOS (for example the macOS equivalent does not use a delegate or datasource) and forgot to delete afterwards. |
Naturalclar
approved these changes
Sep 7, 2020
Naturalclar
changed the title
jainkuniya
pushed a commit
that referenced
this pull request
Sep 7, 2020
# [1.7.0](v1.6.6...v1.7.0) (2020-09-07) ### Features * React-Native-MacOS Support ([#119](#119)) ([ce7d335](ce7d335))
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I am working on a project using react-native-macos and needed access to a picker, so I decided to implement this library for macOS using the NSPopUpButton.
Test Plan
To test that it worked, I built a small sample application that uses the library.
Here is some screenshots of it in use.
What's required for testing (prerequisites)?
A macOS computer running >= 10.14
What are the steps to reproduce (after prerequisites)?
yarnnpx react-native run-macosCompatibility
Checklist
README.mdCHANGELOG.md-> Does not exist?example/App.js) -> Does not currently work as the pod spec relies on this GitHub and the code for macOS is currently not in the pod which is why I made the sample project with a modified pod spec.