New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.56.x Discussion #14

Closed
grabbou opened this Issue Apr 3, 2018 · 88 comments

Comments

Projects
None yet
@grabbou
Contributor

grabbou commented Apr 3, 2018

Please report any major issues and commits to cherry-pick in this thread for discussion.

@grabbou grabbou changed the title from 0.56.x discussion to 0.56.x Discussion Apr 3, 2018

@iRoachie

This comment has been minimized.

iRoachie commented Apr 12, 2018

Could we get this in? facebook/react-native@7469458

@grabbou

This comment has been minimized.

Contributor

grabbou commented Apr 16, 2018

It's not yet cut, so everything in master lands into it.

@Titozzz

This comment has been minimized.

Contributor

Titozzz commented Apr 23, 2018

Does this means we will get babel 7 in 0.56 ♥️ 🎉 ?

@grabbou

This comment has been minimized.

Contributor

grabbou commented Apr 23, 2018

@Titozzz

This comment has been minimized.

Contributor

Titozzz commented Apr 24, 2018

Oh well, I guess I'll wait one more then. Can't wait for this ! Babel 7 is finally coming. 🎉

@maraujop

This comment was marked as off-topic.

maraujop commented Apr 30, 2018

This was requested in 0.55.x discussion #11 (comment) and I'm requesting it again for 0.56.x a fix for TextInputs in iOS facebook/react-native#18278

@MarkOSullivan94

This comment was marked as off-topic.

MarkOSullivan94 commented May 14, 2018

Can we please get this sorted ASAP? facebook/react-native#18095

Don't want to see a lot of RN projects unable to update their Android apps on the store in Nov 2018. Or new projects not being able to publish their apps in August 2018.

@grabbou

This comment has been minimized.

Contributor

grabbou commented May 14, 2018

@MarkOSullivan94

This comment was marked as off-topic.

MarkOSullivan94 commented May 14, 2018

Also curious if there's any plans to include Gradle 3.x support in this release?

facebook/react-native#17747

@Titozzz

This comment has been minimized.

Contributor

Titozzz commented May 14, 2018

I guess it will be nice for react-native to update @MarkOSullivan94 but I'm already using both sdk 26 and gradle 3.0 without issue on production, please tell me if I can help.

@MarkOSullivan94

This comment was marked as off-topic.

MarkOSullivan94 commented May 14, 2018

I don't need help upgrading to either, I'm using target version 27 and the latest version of gradle which comes with AS 3.2 canary 14.

Posting these issues just because there might be a lot of people who are on old versions which will need to be upgraded (target api a higher priority just because it'll stop RN from releasing updates / being publish in the not to distant future)

@vrgimael

This comment was marked as off-topic.

vrgimael commented May 18, 2018

I looked up in many places and couldn't really find any info... what's the status on the 0.56 release?

Thanks

@turnrye

This comment has been minimized.

Member

turnrye commented May 18, 2018

Work is taking place to get master back to a stable state. There are multiple efforts presently underway for this. I suspect that late next week, RC activities will pick up.

@grabbou

This comment has been minimized.

Contributor

grabbou commented May 20, 2018

Yup, currently Hector from Facebook (@hramos) is leading internal efforts on making the CI green again. We will use this thread to notify every one of the progress (if any).

I also hope that CI gets green soon and next RC gets released, but given that we are slowly approaching an end of this month, I'll be looking at the beginning of June as a potential time for next RC.

@rawrmaan

This comment has been minimized.

rawrmaan commented May 21, 2018

Would love to know more about the RN Fabric efforts going into this release. I can't seem to find any information about Fabric, its advantages, roadmap, etc.

@sibelius

This comment was marked as off-topic.

Member

sibelius commented May 23, 2018

Gradle 3 support would make build faster

@FredyC

This comment was marked as off-topic.

FredyC commented May 23, 2018

Also with Gradle 3 it would be easier to use new RN Firebase modules ... https://rnfirebase.io/docs/v4.2.x/installation/migration-guide

Honestly, I tried to go through that migration guide and had some weird issues with so I hope it comes to RN by default.

@noahtallen

This comment was marked as off-topic.

noahtallen commented May 23, 2018

Agreed. We switched to gradle 3+ and build tools 27+ without much issue ourselves, but would be nice to have it up-to-date by default.

@jsdario

This comment was marked as resolved.

jsdario commented May 24, 2018

Is there a PR ready for that? I think gradle 3 is a nice-to-have, but probably should not be a priority for a release candidate, but rather something that can land before v0.57.

@MarkOSullivan94

This comment was marked as off-topic.

MarkOSullivan94 commented May 24, 2018

@jsdario I already posted a link to the PR for it: facebook/react-native#17747

@MarkOSullivan94

This comment was marked as off-topic.

MarkOSullivan94 commented May 26, 2018

Could someone help me with this issue? I've made changes to the React Native Share API a week ago and I'm wanting to test my changes to ensure that Android can now share images now: facebook/react-native#19358

Would love to get the fix done ASAP and get it in for 0.56.x

@grabbou

This comment has been minimized.

Contributor

grabbou commented May 28, 2018

Please keep this thread related to commits that are already merged to React Native master. Meanwhile, if you need any additional help in the main React Native repo, feel free to ping me or Hector.

@kelset

This comment has been minimized.

Collaborator

kelset commented May 31, 2018

A couple of commits I'd like to see in this release:

@rawrmaan

This comment has been minimized.

rawrmaan commented Jun 3, 2018

Got a little bit of clarity on Fabric: https://twitter.com/dan_abramov/status/1003395928831791104

@musicode

This comment was marked as off-topic.

musicode commented Jun 6, 2018

When to release this version?

@kelset

This comment was marked as resolved.

Collaborator

kelset commented Jun 6, 2018

@musicode

Please keep this thread related to commits that are already merged to React Native master. Meanwhile, if you need any additional help in the main React Native repo, feel free to ping me or Hector.

@musicode

This comment was marked as off-topic.

musicode commented Jun 6, 2018

@kelset Is master stable?

@grabbou

This comment has been minimized.

Contributor

grabbou commented Jun 26, 2018

@gnprice

This comment has been minimized.

gnprice commented Jun 27, 2018

EXTRA: I think we should try to get this merged and cherry picked: facebook/react-native#19645

After some deeper debugging of the issue today, that's now a simple one-line bugfix, where the original was a revert of a previous commit that added a feature. So hopefully that now makes it easy to include!

@dulmandakh

This comment has been minimized.

Contributor

dulmandakh commented Jun 27, 2018

please cherry-pick facebook/react-native@77a02c0, so we can remove ReactFragmentActivity and do some code cleanup in 0.57.

@kelset

This comment has been minimized.

Collaborator

kelset commented Jun 28, 2018

Looks like we are getting really close to a stable release in time for the deadline :)

Aside from the commit proposed by @dulmandakh (that deserves mad props for all the PRs he submitted in order to improve the Android support!) I think we would need a couple more:

And I guess we need to keep an eye on #19827 hoping a fix is found soon.

@hramos

This comment has been minimized.

Collaborator

hramos commented Jun 28, 2018

Note to whoever cherry picks these, when adding facebook/react-native@5017b86 to the changelog, please use the updated description (see my comment there).

@dulmandakh

This comment has been minimized.

Contributor

dulmandakh commented Jun 29, 2018

Fix for FlatList with ListHeaderComponent facebook/react-native@dbc2346

@ikesyo

This comment has been minimized.

ikesyo commented Jun 29, 2018

I want facebook/react-native@75a0273 to be cherry-picked.

@futuun

This comment has been minimized.

futuun commented Jul 3, 2018

those 3 commits are fixing issues with Xcode 10, would be nice to have them:
facebook/react-native@75a0273 (for fishhook import)
facebook/react-native@e131fff (for missing config.h in glog)
facebook/react-native@a130239 (for opening invalid simulator (or no simulator at all if you have only xcode beta))

@kelset

This comment has been minimized.

Collaborator

kelset commented Jul 3, 2018

👋 everyone, sorry for keeping you wait; quick update regarding 0.56.0.

Since there are still a couple of open issues related to rc versions that may be "important" issues we are running some more tests updates on real world apps to make sure that it is possible to update to rc.4 and build both iOS/Android and Debug/Release.

Once we made sure that there are positive outcomes, we will release 0.56.0 with prob an extra line or two in both the changelog and the blogpost (that will be published after the npm publish) regarding these issues, in order to hopefully "increase the surface" of developers using the new version and eventually lead to a faster solution for them in 0.56.1.

@SudoPlz

This comment has been minimized.

SudoPlz commented Jul 3, 2018

@kelset Any rough ETA ?? (are we hours, days or weeks away from release?)

@kelset

This comment has been minimized.

Collaborator

kelset commented Jul 3, 2018

Hopefully hours. I've tested tested with 3 different repos(debug/release, ios/Android), and the update worked on all these 3 scenarios :

  • one of our own prod apps
  • plain test app from 0.55.4 to 0.56.rc4 (and uploaded the repo here https://github.com/kelset/rn56-testupdate )
  • another more complex test app with modules-export, .android/.ios files

and submitted a couple of PRs.
Now other devs in the core will review and approve/discuss and hopefully we can release 0.56.0.

Sadly it won't be as perfect as we'd like, but we need to keep moving forward IMHO.

@rozele

This comment has been minimized.

rozele commented Jul 3, 2018

Can we cherry-pick facebook/react-native@5494274 to allow react-native-windows to work with 0.56?

@hramos

This comment has been minimized.

Collaborator

hramos commented Jul 4, 2018

All of the cherry-picks requested above have been added to the 0.56-stable branch and should be released as part of 0.56.0-rc.5. This is the final RC and no further commits will be cherry-picked unless a regression was introduced between rc.4 and rc.5 - we need to promote to stable at some point so we can get moving along.

@hramos

This comment has been minimized.

Collaborator

hramos commented Jul 4, 2018

react-native@0.56.0-rc.5 is out, @rozele, @futuun, @ikesyo, @gnprice, @dulmandakh please take a look and let us know if we can promote rc.5 to become the final, stable 0.56 release 🚀🎉

@dulmandakh

This comment has been minimized.

Contributor

dulmandakh commented Jul 4, 2018

Upgraded 2 projects from 0.55.4 to 0.56.0-rc.5 just fine. On iOS, got React Native version mismatch error and had to open XCode, then run Product -> Clean to fix it. On Android, resolved few conflicts due to changes in gradle files.

@angly-cat

This comment has been minimized.

angly-cat commented Jul 4, 2018

@dulmandakh How did you upgrade, btw? With react-native-git-upgrade? Or just by specifying newer version in package.json?

@dulmandakh

This comment has been minimized.

Contributor

dulmandakh commented Jul 4, 2018

@angly-cat react-native-git-upgrade next

@grabbou grabbou added stable and removed rc labels Jul 4, 2018

@kelset

This comment has been minimized.

Collaborator

kelset commented Jul 5, 2018

0.56.0 has been released

Any future conversation on this thread will be limited to backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.56.0 cut. For new features that you would like to see implemented, refer to #34

If you cannot point to a particular commit on master, then your "bug fix request" likely belongs as a new issue in http://github.com/facebook/react-native/issues.

@kelset

This comment has been minimized.

Collaborator

kelset commented Jul 18, 2018

For 0.56.1 we should aim (IMHO) to release as soon as this is fixed fully: facebook/react-native#19953 (and facebook/metro#181)

Currently it seems that a fix has been merged in master: facebook/react-native@3ac86c3

but there has been a report that is actually still not fixed (sadly). So prob cherry picking that is a start but something else will be required.

@janicduplessis

This comment has been minimized.

janicduplessis commented Sep 2, 2018

Would be nice to include facebook/react-native@b4b594c if we do a patch release, it fixes a regression with TextInput.State.currentlyFocusedField.

@hramos

This comment has been minimized.

Collaborator

hramos commented Sep 6, 2018

It looks like that commit can be applied cleanly on top of 0.56. If you have push access, you can try cherry-picking it onto 0.56-stable and running the bump-version script to tag a new patch release.

@grabbou

This comment has been minimized.

Contributor

grabbou commented Sep 10, 2018

Just did that before we make 0.57 stable (for some reason it doesn't work properly when we release a patch to non-latest release).

Anyway, impressed we didn't have much to cherry-pick and release since then.

@grabbou grabbou removed stable labels Sep 12, 2018

@grabbou

This comment has been minimized.

Contributor

grabbou commented Sep 12, 2018

Closing as 0.57.0 has just hit npm. No future cherry-picks will be accepted unless a security/critical issue arises in the meantime.

@grabbou grabbou closed this Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment