Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS crashes when offset is set to a large number #1201

Closed
mnemanja opened this issue Nov 22, 2019 · 1 comment
Closed

iOS crashes when offset is set to a large number #1201

mnemanja opened this issue Nov 22, 2019 · 1 comment
Labels
bug good first issue help wanted

Comments

@mnemanja
Copy link

I've experienced this by accidentally setting the value of the offset property to 750% and the iOS app would just crash.

<LinearGradient id="gradient2">
  <Stop offset="50%" stopColor={stepThree} />
  <Stop offset="750%" stopColor={stepFour} />
</LinearGradient>

While the value in question is something that would probably never be used for the offset I still believe that it should not hard crash the app.

p.s.
I've used the LinearGradient in combination with a Circle

<Circle
  r={circleDiameter}
  strokeWidth={strokeWidth}
  strokeDasharray="45 200"
  strokeDashoffset="-55"
  transform={{ rotation: 63 }}
  fill="none"
  stroke="url(#gradient0)"
  strokeLinecap="round"
/>
msand added a commit that referenced this issue Jan 4, 2020
@msand
fix(ios): crash when offset is outside range #1201
a2ef51f
msand pushed a commit that referenced this issue Jan 4, 2020
@semantic-release-bot
chore(release): 9.14.0 [skip ci]
1749176 
# [9.14.0](v9.13.6...v9.14.0) (2020-01-04)

### Bug Fixes

* **android:** correct values for measureInWindow, fixes [#1231](#1231) ([3bf07f8](3bf07f8))
* **android:** elements not touchable if below opacity limit ([ebc7220](ebc7220)), closes [#1200](#1200)
* **android:** fix radial gradient vertical center offset scaling ([d5bddd5](d5bddd5))
* **ios:** crash when offset is outside range [#1201](#1201) ([a2ef51f](a2ef51f))
* **web:** fix gesture responder dimensions measurement ([36c20b3](36c20b3))
* extraction of clip rule, fixes [#1233](#1233) ([f93bdde](f93bdde))
* Text color doesn't work with inlineSize [#1225](#1225) ([027b8c1](027b8c1))

### Features

* **android:** support using other native views in e.g. masks ([15b4ac6](15b4ac6))
* **ios:** support using other native views in e.g. masks ([518a3b1](518a3b1))
* **web:** Implement support for event, touch & responder handlers ([60561ec](60561ec))
* **web:** Optimize: only set responders if press handler exists ([23250ad](23250ad))
* Implement display="none" ([3e3ad13](3e3ad13)), closes [#1220](#1220)
@msand msand closed this as completed Jan 4, 2020
@msand
Copy link
Collaborator

msand commented Jan 4, 2020

Released in v10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msand @mnemanja