Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text color doesn't work with inlineSize #1225

Closed
codelayerorg opened this issue Dec 26, 2019 · 4 comments
Closed

Text color doesn't work with inlineSize #1225

codelayerorg opened this issue Dec 26, 2019 · 4 comments

Comments

@codelayerorg
Copy link

Hi there, I can't get fill color working along side with inlineSize. When I set inlineSize, applied fill color is always black no matter the color I set. Any workaround for this?

System:
OS: macOS 10.15.2
CPU: (8) x64 Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz
Memory: 143.74 MB / 8.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 13.3.0 - ~/.nvm/versions/node/v13.3.0/bin/node
Yarn: 1.21.1 - /usr/local/bin/yarn
npm: 6.13.1 - ~/.nvm/versions/node/v13.3.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
IDEs:
Xcode: 11.3/11C29 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.2 => 0.61.2
npmGlobalPackages:
react-native-cli: 2.0.1

Library version: 9.13.6

Steps To Reproduce

  1. Just place a TSpan tag and set inlineSize and fill properties

Sample code

<SvgText x={0} y={0} fontSize={20}>
      <SvgTSpan inlineSize={"100%"} fill={"#FF0000"}>
      Testing word-wrap... Testing word-wrap... Testing word-wrap... Testing word-wrap... 
      </SvgTSpan>
</SvgText>

Red color should be applied to text. Unfortunately that's not what happens.

@msand
Copy link
Collaborator

msand commented Jan 1, 2020

Can you try with the latest commit from the develop branch?

@msand
Copy link
Collaborator

msand commented Jan 1, 2020

import React from 'react';
import {Svg, Text, TSpan} from 'react-native-svg';

export default () => {
  return (
    <Svg width="100%" height="100%">
      <Text x={0} y={20} fontSize={20}>
        <TSpan inlineSize="100%" fill="#FF0000">
          Testing word-wrap... Testing word-wrap... Testing word-wrap... Testing
          word-wrap...
        </TSpan>
      </Text>
    </Svg>
  );
};

msand pushed a commit that referenced this issue Jan 4, 2020
# [9.14.0](v9.13.6...v9.14.0) (2020-01-04)

### Bug Fixes

* **android:** correct values for measureInWindow, fixes [#1231](#1231) ([3bf07f8](3bf07f8))
* **android:** elements not touchable if below opacity limit ([ebc7220](ebc7220)), closes [#1200](#1200)
* **android:** fix radial gradient vertical center offset scaling ([d5bddd5](d5bddd5))
* **ios:** crash when offset is outside range [#1201](#1201) ([a2ef51f](a2ef51f))
* **web:** fix gesture responder dimensions measurement ([36c20b3](36c20b3))
* extraction of clip rule, fixes [#1233](#1233) ([f93bdde](f93bdde))
* Text color doesn't work with inlineSize [#1225](#1225) ([027b8c1](027b8c1))

### Features

* **android:** support using other native views in e.g. masks ([15b4ac6](15b4ac6))
* **ios:** support using other native views in e.g. masks ([518a3b1](518a3b1))
* **web:** Implement support for event, touch & responder handlers ([60561ec](60561ec))
* **web:** Optimize: only set responders if press handler exists ([23250ad](23250ad))
* Implement display="none" ([3e3ad13](3e3ad13)), closes [#1220](#1220)
@msand
Copy link
Collaborator

msand commented Jan 4, 2020

Released in v10

@msand msand closed this as completed Jan 4, 2020
@shafayeatsumit
Copy link

@msand the example you gave doesn't work when I try to add text stroke and inline size.

  <Svg width="100%" height="100%">
    <SvgText
      x={0}
      y={20}
      fontSize={20}
      fill="white"
      stroke="purple"
      fontWeight="bold"
      textAnchor="middle">
      <TSpan x="10" inlineSize="400">
        {persianText}
      </TSpan>
    </SvgText>
  </Svg>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants