Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README - Adding note on uninstalling react-native-cli #65

Merged
merged 2 commits into from Sep 13, 2019
Merged

README - Adding note on uninstalling react-native-cli #65

merged 2 commits into from Sep 13, 2019

Conversation

mrbrentkelly
Copy link
Contributor

Summary

Small update to the README. Adding a note about removing the globally installed react-native-cli before running npx react-native init MyApp --template react-native-template-typescript

#64 (comment)

Test Plan

What's required for testing (prerequisites)?

N/A

What are the steps to reproduce (after prerequisites)?

N/A

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@mrbrentkelly mrbrentkelly mentioned this pull request Sep 13, 2019
Closed
radko93
radko93 requested changes Sep 13, 2019
View reviewed changes
Copy link
Collaborator

@radko93 radko93 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should state that global d react-native-cli is deprecated and it's no longer supported. Can you add a one about that?

@mrbrentkelly
Copy link
Contributor Author

@radko93 good point, I've added a note about the deprecation 👍

@MateusAndrade
Copy link
Member

@radko93 do you think we can merge this already? Also, i think It will be interesting merging #66 and making a new release on npm. 😶

@emin93 emin93 merged commit f6a43f7 into react-native-community:master Sep 13, 2019
@MateusAndrade MateusAndrade mentioned this pull request Sep 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radko93 radko93 radko93 requested changes

@emin93 emin93 emin93 approved these changes

@MateusAndrade MateusAndrade MateusAndrade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrbrentkelly @MateusAndrade @emin93 @radko93