Removing the call to observeValueForKeyPath:ofObject:change:context: … #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2019 09:37
…on super from RCTVideo. If the super class is not actually observing the key, the app will crash. Checking to see if the super class responds to this selector doesn't solve this issue. react-native-video github issue: TheWidlarzGroup#1515 Discussion about this particular problem: https://stackoverflow.com/questions/6574714/whats-wrong-with-this-observevalueforkeypathofobjectchangecontext-implement
CHaNGeTe
approved these changes
Aug 21, 2019
|
When can we merge this PR? <RCTVideo: 0x14c91d650; frame = (0 0; 320 568); layer = <CALayer: 0x2834f3760>>: An -observeValueForKeyPath:ofObject:change:context: message was received but not handled. Key path: status Observed object: <AVPlayerItem: 0x283706bf0, asset = <AVURLAsset: 0x2834577a0, URL = >> Change: { kind = 1; } Context: 0x0 |
beauner69
pushed a commit
to beauner69/react-native-video
that referenced
this pull request
Oct 10, 2019
…consistencyException Removing the call to observeValueForKeyPath:ofObject:change:context: … (rebased from commit f66ca32)
airman00
referenced
this pull request
in DribbleUp/react-native-video
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the call to observeValueForKeyPath:ofObject:change:context: on super from RCTVideo.
If the super class is not actually observing the key, the app will crash. Checking to see if
the super class responds to this selector doesn't solve this issue.
react-native-video GitHub issue: #1515
Discussion about this particular problem: https://stackoverflow.com/questions/6574714/whats-wrong-with-this-observevalueforkeypathofobjectchangecontext-implement