Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Debugging.md #96

Merged
merged 4 commits into from
Oct 30, 2018
Merged

Update Debugging.md #96

merged 4 commits into from
Oct 30, 2018

Conversation

jamonholmgren
Copy link
Member

The new debugging guide is great but the filename is wrong. Also added a screenshot. cc @ryanlntn

Copy link
Contributor

@ryanlntn ryanlntn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Good catch 👍

@Titozzz
Copy link
Collaborator

Titozzz commented Oct 18, 2018

@jamonholmgren Are you sure the screenshot really has value? Maybe it would be better to show how to access remote devices

@jamonholmgren
Copy link
Member Author

@Titozzz I find it's helpful to give people a preview of what they can expect when they do this. I can make it smaller if it's too overpowering?

@Titozzz
Copy link
Collaborator

Titozzz commented Oct 21, 2018

Maybe it's too big... also we could add smaller screenshots of every steps in addition too 😄 ?

@Titozzz
Copy link
Collaborator

Titozzz commented Oct 30, 2018

We need to merge this to fix the docs, we will iterate on it later

@Titozzz Titozzz merged commit b284bf9 into master Oct 30, 2018
@Titozzz
Copy link
Collaborator

Titozzz commented Nov 19, 2018

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

phuongwd pushed a commit to phuongwd/react-native-webview that referenced this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants