Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.60.4 Discussion #130

Open
kelset opened this issue Jul 3, 2019 · 30 comments

Comments

Projects
None yet
@kelset
Copy link
Member

commented Jul 3, 2019

Conversation on this thread are limited to 0.60.4 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.60.4 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.60-stable branch yourself, in order to ensure that the process proceeds smoothly.

@maheshaarkenea

This comment was marked as off-topic.

Copy link

commented Jul 3, 2019

"react-native eject" command not working after this upgrade. i deleted ios and android folder. now i have no option to create those again. created new project and the new xcworkspace file came. cant open it with xcode 10.1. another issue.

@kesha-antonov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Good job guys

@Frekansapp

This comment was marked as off-topic.

Copy link

commented Jul 4, 2019

I think autolinking causing problems with react-native-navigation see here

@gleydson

This comment was marked as off-topic.

Copy link

commented Jul 4, 2019

I had the same problem @Frekansapp!

@Frekansapp

This comment was marked as off-topic.

Copy link

commented Jul 4, 2019

@gleydson did you solve it?

@Ilphrin

This comment has been minimized.

Copy link

commented Jul 4, 2019

Thank you all so much for your awesome work! =D Can't wait to have enough time to contribute myself fur future releases!
I don't see any commit that should be merged in a hurry for next minor release (even though I'd love to see the new jsc-android update and this ScrollView sticky header ;) ), but I'll stay tuned

@ImBeCiliC

This comment has been minimized.

Copy link

commented Jul 4, 2019

Hello this was also posted to 0.59.x and sadly didn't made it into the 0.59.10 release. Can the new Keyboard behaviour on Android come into the next 0.60.x release?
facebook/react-native@d88e470
It's from this old and long discussion facebook/react-native#14045
Thanks

@sunnylqm

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Please cherry pick facebook/react-native@76c50c1

@matamicen

This comment was marked as off-topic.

Copy link

commented Jul 8, 2019

Thank you guys for the effort!

CocoaPod is included in this version, so any ideas how is the new procedure to install for example react-native-firebase for admob? in release 0.58 We had to follow this guide but now with cocoapod included is any other easier way to install it ? any help how to do it ?

Thanks!

@thymikee

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@thymikee thymikee pinned this issue Jul 9, 2019

@IljaDaderko

This comment was marked as resolved.

Copy link
Member

commented Jul 10, 2019

@matamicen most packages will have something called a .podspec file, so to add them through CocoaPods, you just need to point to dir where that .podspec file lives. Here is example with react-native-firebase v5

# Firebase (note you need to include firebase pods as well for features that you use)
  pod 'Firebase', '~> 5.20.0'
  pod 'Firebase/Core', '~> 5.20.0'
  pod 'Firebase/Analytics', '~> 5.20.0'
  pod 'Firebase/DynamicLinks', '~> 5.20.0'
  pod 'Firebase/Messaging', '~> 5.20.0'

  # React-Native libraries (react-native-firebase)
  pod 'RNFirebase', :path => '../node_modules/react-native-firebase/iOS'

From here you just run pod update in your ios dir and it will install everything.

@sunnylqm

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

@dulmandakh Do you mean this one? facebook/react-native@7254bab

@AndrewJack

This comment has been minimized.

Copy link

commented Jul 15, 2019

Can this iOS 13 fix get cherry picked?
facebook/react-native@46bdb41

Related issue: facebook/react-native#25181

@matamicen

This comment was marked as resolved.

Copy link

commented Jul 15, 2019

@matamicen most packages will have something called a .podspec file, so to add them through CocoaPods, you just need to point to dir where that .podspec file lives. Here is example with react-native-firebase v5

# Firebase (note you need to include firebase pods as well for features that you use)
  pod 'Firebase', '~> 5.20.0'
  pod 'Firebase/Core', '~> 5.20.0'
  pod 'Firebase/Analytics', '~> 5.20.0'
  pod 'Firebase/DynamicLinks', '~> 5.20.0'
  pod 'Firebase/Messaging', '~> 5.20.0'

  # React-Native libraries (react-native-firebase)
  pod 'RNFirebase', :path => '../node_modules/react-native-firebase/iOS'

From here you just run pod update in your ios dir and it will install everything.

@IljaDaderko thanks very clear!

@kelset kelset changed the title 0.60.0 Discussion 0.60.3 Discussion Jul 15, 2019

@kelset

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2019

quick update: I changed this conversation to about 0.60.3 aiming for 0.60.4 since Hermes was micdropped during ChainReact 😂

We'll likely do a new release soon-ish, as soon as this fix for the CLI is implemented so that we can cherry pick this facebook/react-native@7254bab

Also, because of Hermes landing in branch directly a few of the CI jobs we have set up in that branch are now failing, which lowers a bit my confidence on ensuring that the releases are as bug free as we can get them to be - so it's likely that patch releases will be small and limited while aiming for a quick rollout of 0.61 (more details about it will arrive in the next couple weeks, we are waiting for some things to land).

@fungilation

This comment has been minimized.

Copy link

commented Jul 15, 2019

To be clear of what you are saying. For CI fixes and larger changes in RN needed to accommodate Hermes, those are going to land in 0.61 instead? So it's reasonable that production apps should wait for 0.61 before using Hermes?

@kelset

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2019

Oh no - sorry I meant that the Hermes commit broke some CI jobs that are set up in the 0.60 branch.

To clarify: you can use Hermes via 0.60.3 even in production (AFAIK - I haven't seen any major issues in the main repo), but simply since the CI is kinda broken in the 0.60-branch it means we have less ways to detect eventual issues that may be caused by some cherry picks.

But the CI on master branch is actually been improved a lot since 0.60-branch was cut, and it's green again from what I can see so 0.61-branch will have a more stable and reliable CI.

@janicduplessis

This comment has been minimized.

Copy link

commented Jul 16, 2019

facebook/react-native@88e18b6 to fix blob memory leak on Android. Might also need janicduplessis/react-native@6c2f4f5 (hermes has not landed on master so can't land this diff) which caused a crash for me when trying out hermes.

@kelset

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

@janicduplessis I think that that diff will have to be done as PR against the 0.60-branch to see it happen in 0.60.x because Hermes was landed first in the branch so I don't think that the code will be precisely the same once it's on master (so yeah, I fear you may having to end up doing that PR twice 😓)

@moonstruck

This comment was marked as resolved.

Copy link

commented Jul 17, 2019

@Ivan-Stashak-CardinalPeak Please report the issue to https://github.com/react-native-community/react-native-webview or React Native repo. Purpose of this thread is not issue reporting.

Conversation on this thread are limited to 0.60.3 release's major issues and cherry-pick requests from commits that are already on master.

@mjmasn

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

facebook/react-native@b432b8f please @kelset!

@matpaul

This comment has been minimized.

Copy link

commented Jul 18, 2019

svg animation with nativeDriver
facebook/react-native@bdc530b

@thymikee

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

@artdent

This comment has been minimized.

Copy link

commented Jul 18, 2019

facebook/react-native@6ef9106 would be a useful cherrypick - it fixes use_native_modules! in certain projects that use Cocoapods. It's a fix spun out of facebook/react-native#25349, which is a broader umbrella issue.

@janicduplessis

This comment has been minimized.

Copy link

commented Jul 18, 2019

@kelset Actually the second commit doesn't depend on hermes landing on master so I created a PR for it facebook/react-native#25720, when it lands we can cherry pick both commits.

@kelset

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

Ok, thanks for the clarification @janicduplessis - I've subscribed to the new PR (thanks for doing it!) so I should be aware of when it lands.

@artdent as I have commented on the issue, that fix will only land on 0.61 - the commit you are referring to is only part 1 and it will involve breaking changes (as far as I am aware of).

Aside from all of this, couple of extra things:

  • because of this facebook/react-native#25622 basically we need to ensure that 0.60 uses 0.54.x of Metro (no ^ in the deps)
  • @cpojer did a new 0.60.4 release with some Hermes related fixes sooo yeah, let's aim to cherry pick for 0.60.5

@kelset kelset changed the title 0.60.3 Discussion 0.60.4 Discussion Jul 18, 2019

@artdent

This comment has been minimized.

Copy link

commented Jul 19, 2019

@kelset The breaking changes are in part 2. Part 1 doesn't attempt to fix use_frameworks!; it just fixes the missing header file <double-conversion/double-conversion.h> as reported in facebook/react-native#25349. I've just verified locally that cherry-picking facebook/react-native@6ef9106 into RN 0.60.3 fixes the missing header file in my project without introducing any other problems.

@thymikee

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

@kelset the 0.x is a special case in semver indicating unstable APIs and ^0.54.1 will resolve to 0.54.x. See: https://jubianchi.github.io/semver-check/#/^0.54.1/0.55.0. It seems like folks there have issues with their package manager (npm, why I'm not surprised). The issue is metro-source-map being explicitly set at 0.55.

@kelset

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

@artdent oh ok awesome, thanks for the clarification!

@thymikee yeah what I meant up there with 0.54.x was simply "the latest version of 54 of which I can't remember the precise number" ;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.