0.58.5 Discussion

[kelset]

Conversation on this thread are limited to 0.58.5 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.

[Bardiamist]

I updated from 0.58.4 to 0.58.5 today and now I have warning when call fetch with saga.
Warning: somthing about n.slice on next code: yield call(fetch, 'apiUrl', requestOprions). But it works properly.
Works wothout warning: await fetch('apiUrl', requestOprions)
May be in future will create issue when will understand what the right place for this.
Can't make to reproduce demo because expo snack not using react-native@0.58.5 now.

[dmainas]

Fix Inverted Horizontal ScrollView on Android facebook/react-native@32cb9ec

[thientnc-ibl]

Map TextInput textContentType strings to Objective-C constants facebook/react-native@a89fe41

[sunnylqm]

Please cherry pick:
facebook/react-native@d9489c4

[grabbou]

@mikehardy I wouldn't say it better!

It's not the first time the ReactActivity commit comes up @nihar108, but given it's breaking and not trivial to merge, we decided to keep it for the 0.59 RC.

@lorenc-tomasz there's nothing to do to upgrade in between patch releases rather than just bumping your package.json.

[grabbou]

I've been working on 0.59.0-rc.3 today and some fixes to the CLI. I am going to work on 0.58.6 tomorrow.

[fungilation]

Any rough estimate of when for 0.59.0 release?

[grabbou]

We want RC to stabilize for a week and then, we will cut stable.

…

On Wed, 27 Feb 2019 at 23:25, Gary Fung ***@***.***> wrote: Any rough estimate of when for 0.59.0 release? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#95 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxneSBNK1bciEDptwE4dMwwbDic9Dks5vRwXGgaJpZM4bEz6b> .

[grabbou]

Cherry-picked commits, pushed to the CI to test if it's all green. I am half-way done with manual checks on RNTester and react-native init'ed app - will resume to this in few hours.

[kelset]

0.58.6 is out - thanks everyone!
New issue #97