Fix UI styles #57
Merged
Fix UI styles #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @RubenSandwich I'll merge this right now but we can definitely discuss further. |
|
@lucasbento No worries, that makes sense. Another idea for the loading animation is to use a skeleton screen. |
|
@RubenSandwich: that would be so cool, the spinner is there just because we did it in a rush. Would you have time to open a PR implementing it? |
|
@lucasbento Yeah give me about a week and I'll have a PR. |
|
@RubenSandwich: awesome! created an issue for it: #58. Thank you for your work 🙂 |
|
@lucasbento No worries, thanks for managing this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR puts back the logo that we used for loading and add a little bit of margin below the title.
Checklist
README.md(if needed)