Feat/Android locale support #233

Inbal-Tish · 2020-07-27T14:01:40Z

Summary

Currently, DateTimePickers on Android use system locale and not the app one, so a user with English system language and Spanish app language would see a picker in English instead of Spanish. See issue #82
I added support for passing 'locale' prop, the same way as in iOS, and get the picker in that locale (date picker will localize the dialog header and calendar's month and days of the week views).
As part of this effort, I added the 'positiveButtonLabel' and 'negativeButtonLabel' props to help pass localized strings to the buttons labels.

Uncomment App.js lines #214-216 to pass the appropriate props to see the example.

Compatibility

OS	Implemented
Android	✅

Checklist

[✅ ] I have tested this on a device and a simulator
[✅ ] I added the documentation in README.md
[✅ ] I mentioned this change in CHANGELOG.md
[✅ ] I updated the typed files (TS and Flow)
[ ✅] I added a sample use of the API in the example project (example/App.js)

…. Adding support for passing positive and negative dialog buttons labels (good for passing localized labels).

…cker into feat/Android_locale_support

…nd/datetimepicker into feat/Android_locale_support # Conflicts: # android/src/main/java/com/reactcommunity/rndatetimepicker/RNConstants.java # android/src/main/java/com/reactcommunity/rndatetimepicker/RNDatePickerDialogFragment.java # android/src/main/java/com/reactcommunity/rndatetimepicker/RNDatePickerDialogModule.java # package-lock.json # src/datetimepicker.android.js

vonovak

hello and thanks for working on this. I have some questions I'd like to discuss to see how to best proceed about this. Thank you!

vonovak · 2020-07-27T17:01:47Z

android/gradle/wrapper/gradle-wrapper.properties

@@ -0,0 +1,6 @@
+#Wed Jul 22 14:26:15 IDT 2020


why do you belive these gradle files should be included in the repo?

These are probably auto-generated when running the example project. Do you think they are not necessary?

I think they are not necessary

vonovak · 2020-07-27T17:07:17Z

android/src/main/java/com/reactcommunity/rndatetimepicker/RNDatePickerDialogFragment.java

@@ -86,6 +87,10 @@ DatePickerDialog getDialog(
                  display
          );
        default:
+          if (args != null && args.containsKey(RNConstants.ARG_LOCALE)) {
+            // for header (NOTE: will change the app locale)
+            Locale.setDefault(getLocale(args));


It's quite possible there is no other way to localize the pickers, but this seems like an action that can have far-reaching consequences.

on ios the prop just "overrides the system default with a specific locale." - that is a "safe way" of specifying locale.

Here, the call would have side effects beyond the datepicker, and I'm not sure we want to take that path. Seem to me that code like this should probably be called from userland upon app start. What do you think?

(also applies to activityContext.getResources().getConfiguration().setLocale(getLocale(args))).

I know and I do understand your point. I was looking for a way to localize it without localizing the entire app but couldn't find another way. I was also thinking that passing the 'locale' prop to localize the picker is made for an already localized app when the user what to have the picker in the app's locale, not the device's. Thus no real harm is done when we change the locale this way. We can add a note to these side-effects when using this feature. What do you think?

I would prefer to not do it this way. I'm not even sure setting locale is a job for this module, maybe it should be done in the scope of some different package..

edit: since this seems like an often-requested feature, I'm in support of supporting locale change.
I would prefer for this locale-changing logic to be exposed via a @ReactMethod that users can call. That will express the side effect more clearly. Such way is more clear for the consumers of the library

vonovak · 2020-08-14T10:16:13Z

@Inbal-Tish would you please address the review? I'd like to merge the PR once the comments are addressed. Thank you!

removing auto-generated android files

Removing auto-generated Android file gradle-wrapper

Removing auto-generated Android files gradlew

Inbal-Tish · 2020-10-13T13:10:02Z

@vonovak Hi. Sorry I didn't have the time to get to it again. Hopefully soon...

marvin-42 · 2020-11-12T09:30:17Z

Any progress with this?

pauloaapereira · 2021-02-09T16:44:47Z

Any progress on this now in 2021? :(
Thanks

nartenergy · 2021-04-22T08:31:19Z

Any update on this??

vonovak · 2021-04-22T18:44:34Z

hello to everyone commenting; as I explained in #313, we're looking for backers that would support the development of this module and due to reasons explained in the post, I no longer actively develop this module (and seems like other maintainers don't have much time either). In order to move this forward, I invite you to do any of the following:

take this PR, address comments from code review and open another PR that me or other maintainers will merge
support the module via one of the offered sponsorship options and once we collect enough balance, I would take a look at it.
(shamlesss plug) you can hire me. I'm sorry if this sounds like I'm trying to sell anything; in fact, I have plenty of work to do elsewhere, I am just listing the options :)

Thank you :)

vonovak · 2021-12-11T14:35:57Z

closed by #540 (v5 release)

KMathisGit · 2023-05-08T20:35:09Z

Should re-open this as the v5 release (removing locale prop) was reverted in v5.1.0.

Inbal-Tish added 10 commits July 26, 2020 14:07

DateTimePicker - Android - Adding support for 'locale' on mode 'date'…

c246825

…. Adding support for passing positive and negative dialog buttons labels (good for passing localized labels).

commenting locale example

a05e229

Merge branch 'master' of github.com:react-native-community/datetimepi…

e38f3f0

…cker into feat/Android_locale_support

Adding locale support for Android

d9dbd02

passing buttons labels to time picker dialog

b03d8a0

editing readme

6fc6f51

fix readme links

4d8c291

update type file

6dfbfa0

editing changelog

9b7cfc5

vonovak self-assigned this Jul 27, 2020

vonovak reviewed Jul 27, 2020

View reviewed changes

Inbal-Tish added 3 commits August 20, 2020 10:04

Delete gradlew.bat

b3f4b33

removing auto-generated android files

Delete gradle-wrapper.properties

28dfba2

Removing auto-generated Android file gradle-wrapper

Delete gradlew

c648a86

Removing auto-generated Android files gradlew

hondaholics approved these changes Sep 2, 2020

View reviewed changes

clementbmn approved these changes Oct 12, 2020

View reviewed changes

1Jesper1 mentioned this pull request Oct 11, 2021

Why is locale prop IOS only? #503

Closed

vonovak mentioned this pull request Dec 11, 2021

feat: remove locale prop #540

Merged

5 tasks

vonovak closed this Dec 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/Android locale support #233

Feat/Android locale support #233

Inbal-Tish commented Jul 27, 2020

vonovak left a comment

vonovak Jul 27, 2020

Inbal-Tish Jul 28, 2020

vonovak Aug 14, 2020

vonovak Jul 27, 2020

Inbal-Tish Jul 28, 2020

vonovak Aug 10, 2020 •

edited

vonovak commented Aug 14, 2020

Inbal-Tish commented Oct 13, 2020

marvin-42 commented Nov 12, 2020

pauloaapereira commented Feb 9, 2021

nartenergy commented Apr 22, 2021

vonovak commented Apr 22, 2021 •

edited

vonovak commented Dec 11, 2021

KMathisGit commented May 8, 2023

Feat/Android locale support #233

Feat/Android locale support #233

Conversation

Inbal-Tish commented Jul 27, 2020

Summary

Compatibility

Checklist

vonovak left a comment

Choose a reason for hiding this comment

vonovak Jul 27, 2020

Choose a reason for hiding this comment

Inbal-Tish Jul 28, 2020

Choose a reason for hiding this comment

vonovak Aug 14, 2020

Choose a reason for hiding this comment

vonovak Jul 27, 2020

Choose a reason for hiding this comment

Inbal-Tish Jul 28, 2020

Choose a reason for hiding this comment

vonovak Aug 10, 2020 • edited

Choose a reason for hiding this comment

vonovak commented Aug 14, 2020

Inbal-Tish commented Oct 13, 2020

marvin-42 commented Nov 12, 2020

pauloaapereira commented Feb 9, 2021

nartenergy commented Apr 22, 2021

vonovak commented Apr 22, 2021 • edited

vonovak commented Dec 11, 2021

KMathisGit commented May 8, 2023

vonovak Aug 10, 2020 •

edited

vonovak commented Apr 22, 2021 •

edited