deviceName not updating when user updates device name on device

[chrisdrackett]

Summary

Version	8.1.4
Affected OS	iOS
OS Version	14.7

Current behavior

after changing the device name and then calling DeviceInfo.getDeviceName() I'm still getting the old value.

1. open app (device name reports as iPhone)
2. close app and change device name in settings to iPhone new
3. open app and call DeviceInfo.getDeviceName()
4. returns iPhone and not iPhone new

Expected behavior

DeviceInfo.getDeviceName() should report the current device name

[mikehardy]

That's odd. Looks like we fetch it dynamically:

react-native-device-info/ios/RNDeviceInfo/RNDeviceInfo.m

Lines 146 to 157 in 0e1319c

	- (NSString *) getDeviceName {
	UIDevice *currentDevice = [UIDevice currentDevice];
	return currentDevice.name;
	}
	RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD(getDeviceNameSync) {
	return self.getDeviceName;
	}
	RCT_EXPORT_METHOD(getDeviceName:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) {
	resolve(self.getDeviceName);
	}

How did it go when you reached in there and added some debugging print statements + watched the logs? Is the system API we use behaving correctly? Does it mention anything in the related documentation about caching behavior in the system?

[schie]

@mikehardy in the js/ts side, it is memo-ized. We can remove the memo to resolve this issue.

[mikehardy]

Ah ha! @chrisdrackett if you post a PR removing the memoization there, can happily merge + release

tangent: oh man, the semantic release bot is golden here @schie, thank you so much for that

[rndi-bot]

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is sti ll here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solu tions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

[rndi-bot]

🎉 This issue has been resolved in version 8.4.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[anujwits]

This issue is still persist for android devices.
Android Version: 11
react-native-device-info: 8.7.0

Please suggest a workaround.

[mikehardy]

No workaround to suggest, please investigate using standard troubleshooting techniques / debugging tools and if there's a problem, we can merge and release a PR really quickly

[anujwits]

Behaviour for this is strange, this is working on some devices and not for others.
Do we need to give some permission at device level?

[mikehardy]

previously needed bluetooth, not supposed to need it now

[anujwits]

Yes no bluetooth permission is required. This work's for the first time.
If i update phone name, then updated name is not reflecting.

[mikehardy]

@anujwits then this comment drives progress on your part:

How did it go when you reached in there and added some debugging print statements + watched the logs? Is the system API we use behaving correctly? Does it mention anything in the related documentation about caching behavior in the system?

[jessenovotny]

Does not work on iOS with v10.4.0. No matter what name our devices getDeviceName() always returns iPad. I'm not much of a iOS developer so unsure the best way to troubleshoot. Please advise

[jessenovotny]

Turns out this is an issue with iOS 16. For anyone who winds up here, please refer to the issue documented here: #1516