Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added getSerialNumber for windows #1287

Merged
merged 10 commits into from Aug 12, 2021

Conversation

KewtonV
Copy link
Contributor

@KewtonV KewtonV commented Aug 12, 2021

Description

Added getSerialNumber() on windows that allows get Serial number from SMBIOS.

Compatibility

OS Implemented
iOS
Android
Windows

Checklist

  • [ X] I have tested this on a device/simulator for each compatible OS
  • [ X] I added the documentation in README.md
  • I updated the typings files (privateTypes.ts, types.ts)
  • I added a sample use of the API (example/App.js)

Screenshot of SerialNumber working in windows plataform.
image

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for posting this!

@mikehardy mikehardy added the pending-merge looks good, waiting on CI or similar label Aug 12, 2021
@mikehardy mikehardy merged commit 5b44183 into react-native-device-info:master Aug 12, 2021
rndi-bot pushed a commit that referenced this pull request Aug 12, 2021
# [8.2.0](v8.1.7...v8.2.0) (2021-08-12)

### Features

* Added getSerialNumber for windows ([#1287](#1287)) ([5b44183](5b44183))
@rndi-bot
Copy link
Collaborator

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mikehardy mikehardy removed the pending-merge looks good, waiting on CI or similar label Jun 4, 2022
WictorWilnd added a commit to WictorWilnd/react-native-device-info that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants