New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added getSerialNumber for windows #1287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KewtonV
requested review from
GantMan,
Johan-dutoit,
machour and
mikehardy
as code owners
August 12, 2021 22:21
mikehardy
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for posting this!
rndi-bot
pushed a commit
that referenced
this pull request
Aug 12, 2021
# [8.2.0](v8.1.7...v8.2.0) (2021-08-12) ### Features * Added getSerialNumber for windows ([#1287](#1287)) ([5b44183](5b44183))
🎉 This PR is included in version 8.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
WictorWilnd
added a commit
to WictorWilnd/react-native-device-info
that referenced
this pull request
Feb 27, 2023
# [8.2.0](react-native-device-info/react-native-device-info@v8.1.7...v8.2.0) (2021-08-12) ### Features * Added getSerialNumber for windows ([#1287](react-native-device-info/react-native-device-info#1287)) ([d8cd1fa](react-native-device-info/react-native-device-info@d8cd1fa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
getSerialNumber()
on windows that allows get Serial number from SMBIOS.Compatibility
Checklist
README.md
privateTypes.ts
,types.ts
)example/App.js
)Screenshot of SerialNumber working in windows plataform.