fix(getDeviceName): un-memoize device name so it updates #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes memoization of device name because the device's name can be changed resolves #1272 Co-authored-by: @chrisdrackett
moves function from `memoizedStringGetters` to `nonMemoizedStringGetters`
schie
requested review from
GantMan,
Johan-dutoit,
machour and
mikehardy
as code owners
4 tasks
mikehardy
changed the title
mikehardy
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
LGTM! Thanks for fixing this. Should be a squash-merge since the test is in a separate commit from the fix, otherwise master won't be git bisectable as it'll fail testing on the first commit without the second
Please feel free to merge as soon as CI looks reasonable - in fact it's just iOS Android on-device stuff now and the jest already passed so this is good to go IMHO
mikehardy
added
hacktoberfest-accepted
|
🎉 This PR is included in version 8.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
WictorWilnd
added a commit
to WictorWilnd/react-native-device-info
that referenced
this pull request
Feb 27, 2023
## [8.4.3](react-native-device-info/react-native-device-info@v8.4.2...v8.4.3) (2021-10-26) ### Bug Fixes * **getDeviceName:** un-memoize device name so it updates ([#1332](react-native-device-info/react-native-device-info#1332)) ([67b7155](react-native-device-info/react-native-device-info@67b7155)), closes [#1272](react-native-device-info/react-native-device-info#1272)
wdavis122
added a commit
to wdavis122/react-native-device-info
that referenced
this pull request
Jun 6, 2024
## [8.4.3](react-native-device-info/react-native-device-info@v8.4.2...v8.4.3) (2021-10-26) ### Bug Fixes * **getDeviceName:** un-memoize device name so it updates ([#1332](react-native-device-info/react-native-device-info#1332)) ([7026844](react-native-device-info/react-native-device-info@7026844)), closes [#1272](react-native-device-info/react-native-device-info#1272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDeviceNamegetDeviceNameDescription
Fixes #1272
all real credit goes to @chrisdrackett for noticing this issue and the initial PR.
Compatibility
Checklist
README.mdprivateTypes.ts,types.ts)example/App.js)