Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using getSupportedPlatformInfoFunctions #1088

Merged
merged 7 commits into from Oct 7, 2020
Merged

using getSupportedPlatformInfoFunctions #1088

merged 7 commits into from Oct 7, 2020

Conversation

schie
Copy link
Contributor

@schie schie commented Oct 7, 2020

Description

re #1085

updates the following functions to use getSupportedPlatformInfoFunctions(...)

  • isPinOrFingerprintSet*
  • getFontScale*
  • getInstallerPackageName*
  • getApiLevel*
  • getBuildId*
  • getUsedMemory*

Compatibility

OS Implemented
iOS ✅
Android ✅
Windows ✅

Checklist

  • I have tested this on a device/simulator for each compatible OS
    • able to confirm for iOS and android, but not windows
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (privateTypes.ts, types.ts)
  • I added a sample use of the API (example/App.js)

@schie
refactor(src/index.ts): rewriting getUsedMemory*
c524cdd 
rewrites `getUsedMemory` and `getUsedMemorySync` to use `getSupportedPlatformInfoFunctions`

re #1085
@schie
refactor(src/index.ts): rewriting getBuildId*
50cc7cd 
rewrites `getBuildId` and `getBuildIdSync` to use `getSupportedPlatformInfoFunctions`

re #1085
@schie
refactor(src/index.ts): rewriting getApiLevel*
4071c3b 
rewrites functions to use ``getSupportedPlatformInfoFunctions`

re #1085
@schie
refactor(src/index.ts): rewriting getInstallerPackageName*
749ca99 
rewrites functions to use ``getSupportedPlatformInfoFunctions`

re #1085
@schie
refactor(src/index.ts): rewriting getFontScale*
5719539 
rewrites functions to use ``getSupportedPlatformInfoFunctions`

re #1085
@schie
refactor(src/index.ts): rewriting isPinOrFingerprintSet*
d47df78 
rewrites functions to use ``getSupportedPlatformInfoFunctions`

re #1085
@schie
refactor(src/index.ts): rewriting getCarrier*
7952fb1 
rewrites functions to use ``getSupportedPlatformInfoFunctions`

re #1085
mikehardy
mikehardy approved these changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, less than half the lines worth of space, the info content of this is so much higher but not so terse we're doing a Perl one-liner

@mikehardy mikehardy merged commit 5e57696 into react-native-device-info:master Oct 7, 2020
@schie schie deleted the using-getSupportedPlatformInfoFunctions branch October 7, 2020 14:09
@mikehardy mikehardy added the hacktoberfest-accepted Let's plant some trees label Oct 11, 2020
ts-ign0re pushed a commit to ts-ign0re/react-native-device-info that referenced this pull request Oct 20, 2020
@schie @ts-ign0re
chore(refactor): convert a batch of APIs to getSupportedPlatformInfoF…
18f2f77 
…unctions (react-native-device-info#1088)

* refactor(src/index.ts): rewriting `getUsedMemory*`

rewrites `getUsedMemory` and `getUsedMemorySync` to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getBuildId*`

rewrites `getBuildId` and `getBuildIdSync` to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getApiLevel*`

rewrites functions to use ``getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getInstallerPackageName*`

rewrites functions to use ``getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getFontScale*`

rewrites functions to use ``getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `isPinOrFingerprintSet*`

rewrites functions to use ``getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getCarrier*`

rewrites functions to use ``getSupportedPlatformInfoFunctions`

re react-native-device-info#1085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@GantMan GantMan Awaiting requested review from GantMan GantMan is a code owner

@Johan-dutoit Johan-dutoit Awaiting requested review from Johan-dutoit Johan-dutoit is a code owner

@machour machour Awaiting requested review from machour machour is a code owner

Assignees
No one assigned
Labels
hacktoberfest-accepted Let's plant some trees
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schie @mikehardy