Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completing getSupportedPlatformInfoFunctions conversion #1095

Merged
merged 11 commits into from Oct 13, 2020
Merged

completing getSupportedPlatformInfoFunctions conversion #1095

merged 11 commits into from Oct 13, 2020

Conversation

schie
Copy link
Contributor

@schie schie commented Oct 13, 2020

Description

Fixes #1085

Updates the following functions to use getSupportedPlatformInfoFunctions

  • getProduct*
  • supported32BitAbis*
  • getInstallReferrer*
  • getIncremental*
  • getSecurityPatch*
  • getBaseOs*
  • getTags*
  • getHost*
  • getFingerprint*
  • getIpAddress*
  • getSerialNumber*

This should be all of the remaining conversions.

Compatibility

OS Implemented
iOS
Android
Windows

Checklist

  • I have tested this on a device/simulator for each compatible OS
    • tested on iOS and Android, but unable to do so on Windows
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (privateTypes.ts, types.ts)
  • I added a sample use of the API (example/App.js)

rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
rewrites functions to use `getSupportedPlatformInfoFunctions`

re #1085
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much deletion even diff can't always put the chunks together, thanks a bunch for these. I'm in the middle of a work crunch and don't have CI set up really or semantic-release so putting it through a quick QA cycle and cranking out a release takes a little time, but I'll do a release of this before too long to make sure it settles in. Can't imagine there will be a problem, more just to set expectations on timing

Cheers!

@mikehardy mikehardy merged commit 5f048f6 into react-native-device-info:master Oct 13, 2020
@schie schie deleted the much-excite branch October 13, 2020 02:42
@schie
Copy link
Contributor Author

schie commented Oct 13, 2020

@mikehardy,

No worries!

We all understand the struggles.

October ends up being somewhat of a downtime for me every year — quite the coincidence for Hacktoberfest.

I plan on adding jest tests in a GitHub action, so expect that maybe sometime this week; It should take some of the load off someone's shoulders.

Do you have any resources on how you'd like to perform releases? I can look into getting that setup; maybe get a ball rolling.

@mikehardy
Copy link
Collaborator

Do I have ideas for release :-) :-) - semantic-release is the gold standard I think, react-native-webview for instance works beautifully and I believe react-native-share also has it all set up and working.

I'm pro-delegation and don't mind mistakes as long as someone is trying their best. If you want to set up a little testing and semantic-release I can grant power on the repo and the npmjs package repository

I have worked on react-native-firebase's CI a lot and those .github workflows are pretty good with regards to starting an iOS and Android emulator and running an app although those E2E tests are extraordinarily complex. I think simply building the app for iOS and Android along with jest tests would be an amazing first step, and then either semantic-release or a "workflow_dispatch" triggered publish

Those are the ideas anyway :-)

@schie
Copy link
Contributor Author

schie commented Oct 13, 2020

Sounds good to me.

I'll start going through the repos you've mentioned, then set up jest testing in a GH action.

ts-ign0re pushed a commit to ts-ign0re/react-native-device-info that referenced this pull request Oct 20, 2020
…rsion (react-native-device-info#1095)

* refactor(src/index.ts): rewriting `getSerialNumber*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getIpAddress*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getFingerprint*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getHost*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getTags*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getBaseOs*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getSecurityPath*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getIncremental*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getInstallReferrer*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `supported32BitAbis*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085

* refactor(src/index.ts): rewriting `getProduct*`

rewrites functions to use `getSupportedPlatformInfoFunctions`

re react-native-device-info#1085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRYing up index code base
2 participants