Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add iphone 12 info #1099

Merged
merged 1 commit into from Oct 15, 2020
Merged

add iphone 12 info #1099

merged 1 commit into from Oct 15, 2020

Conversation

stevelyc
Copy link
Contributor

@stevelyc stevelyc commented Oct 15, 2020 •
edited

add iPhone 12 device info

Compatibility

OS Implemented
iOS ✅
Android ✅❌
Windows ✅❌

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (privateTypes.ts, types.ts)
  • I added a sample use of the API (example/App.js)

mikehardy
mikehardy approved these changes Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'll do a release with these so all those people that wait in long lines for their new phone can have their device info correct when you code-push ;-)

@mikehardy mikehardy merged commit 15a1ada into react-native-device-info:master Oct 15, 2020
@mikehardy
Copy link
Collaborator

Launched https://github.com/react-native-community/react-native-device-info/releases/tag/v6.2.1 !

ts-ign0re pushed a commit to ts-ign0re/react-native-device-info that referenced this pull request Oct 20, 2020
@stevelyc @ts-ign0re
fix(ios): add iphone 12 device id / notch info (react-native-device-i…
6da01dd 
…nfo#1099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

@GantMan GantMan Awaiting requested review from GantMan GantMan is a code owner

@Johan-dutoit Johan-dutoit Awaiting requested review from Johan-dutoit Johan-dutoit is a code owner

@machour machour Awaiting requested review from machour machour is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevelyc @mikehardy