fix(example, windows): Define an explicit 10.0 in example project to use latest windows 10 sdk #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # windows/code/RNDeviceInfoCPP.h
namrog84
requested review from
mikehardy,
machour,
GantMan,
Johan-dutoit and
schie
as code owners
4 tasks
namrog84
changed the title
namrog84
changed the title
mikehardy
approved these changes
Jun 4, 2022
|
🎉 This PR is included in version 9.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
WictorWilnd
added a commit
to WictorWilnd/react-native-device-info
that referenced
this pull request
Feb 27, 2023
## [9.0.2](react-native-device-info/react-native-device-info@v9.0.1...v9.0.2) (2022-06-04) ### Bug Fixes * **example, windows:** Define an explicit 10.0 in example project to use latest windows 10 sdk ([#1424](react-native-device-info/react-native-device-info#1424)) ([2b2abfd](react-native-device-info/react-native-device-info@2b2abfd)), closes [#1288](react-native-device-info/react-native-device-info#1288)
wdavis122
added a commit
to wdavis122/react-native-device-info
that referenced
this pull request
Jun 6, 2024
## [9.0.2](react-native-device-info/react-native-device-info@v9.0.1...v9.0.2) (2022-06-04) ### Bug Fixes * **example, windows:** Define an explicit 10.0 in example project to use latest windows 10 sdk ([#1424](react-native-device-info/react-native-device-info#1424)) ([92c4db6](react-native-device-info/react-native-device-info@92c4db6)), closes [#1288](react-native-device-info/react-native-device-info#1288)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example project didn't have a defined windows 10 sdk, so for some users it might use a cached older version.
Change it to be explicitly using 10.0 (use latest installed version) to minimize any potential confusion or issue.
https://i.imgur.com/Ldfn81S.png
Compatibility
Checklist
README.mdprivateTypes.ts,types.ts)example/App.js)Tested on a relatively fresh clone and install of things. I only have VS2022 and windows sdk versions 10.0.19041.0 and 10.0.20348.0 installed.
https://i.imgur.com/JEtmkgg.png