Export react-native-device-info to be compatible with destructured ES6 imports

[Taym95]

Description

Fixed issue #723

Checklist

• I have tested this on a device/simulator for each compatible OS
• I added the documentation in README.md
• I mentioned this change in CHANGELOG.md
• I updated the typings files (deviceinfo.d.ts, deviceinfo.js.flow)
• I updated the dummy web/test polyfill (default/index.js)
• I added a sample use of the API (example/App.js)

[mikehardy]

I like the idea but I wish this didn't add essentially a duplicate entry for each function. Is there any way (breaking or non-breaking) to do this without duplicating each function entry? Just trying to keep the barrier as low as possible for people that propose PRs - we already have like 5 things we ask people to do :-)

[Taym95]

Yeah, I got your point, but unfortunately, this is the only way I found to implement destructured ES6 imports!

[mikehardy]

ok - I will likely merge but I want to think on it just a bit more by looking at other modules to see how they did it (usually I examine react-native-community/netinfo) - maybe there's nothing to be done but maybe there's an organizational trick I/we could use

[Taym95]

Yes absolutely, That is exactly what I did, I checked how react-native-community/netinfo implemented it, but maybe we can found something better.

[mikehardy]

Man, I guess it's just verbose then. Some things javascript is great at. Some things, not so much...module systems... 🤷‍♂️

[Taym95]

Yes exactly, I removed duplicate function implementation, so now contributor can add function to be exported :

export function getExample() {
  return RNDeviceInfo.example;
}

then add it to default export :

export default {
	//other functions
	...,
	getExample
}

[mikehardy]

Thanks for your patience! Big refactor and release coming up as a v3, this will be in it