Fix bug where getModel return undefined because deviceId is undefined #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
added a commit
to mikehardy/react-native-device-info
that referenced
this pull request
Sep 9, 2019
|
Obsoleted by mikehardy@a7129c1 (I wanted to keep the different variable name, but obviously I needed to use it) - will be released as rc.5 shortly - thanks for reporting this @rnnyrk ! |
mikehardy
added a commit
to mikehardy/react-native-device-info
that referenced
this pull request
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can't find a related issue, but when testing the RC I found that
deviceIdingetModelwould be undefined because of a inconsistency of the deviceId const ingetModel.Compatibility
Checklist
All others seem unrelated ;)
README.mdCHANGELOG.mddeviceinfo.d.ts,deviceinfo.js.flow)default/index.js)example/App.js)