fix: android use googlePlayServicesIidVersion if available #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
requested review from
GantMan,
Johan-dutoit and
machour
as code owners
|
@Johan-dutoit I tested this in all the variations I could think of, I think it's good to go but a second pair of eyes is best 👀 |
|
LGTM 🔥 |
This is the outcome of a react-native-community discussion with the goal of avoiding downloading multiple gradle versions and/or loading multiple versions at the same time react-native-community/discussions-and-proposals#151 (comment)
Makes the change to an iid-specific play services library dependency truly backwards compatible and Fixes react-native-device-info#802
mikehardy
force-pushed
the
gradle-iid-dep-fixup
branch
from
3655d86
to
b5f8320
Compare
|
released as |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#802 showed that the initial attempt at a backwards-compatible dependency on the specific iid library prompted by #746 vs the full play services library had an error in the pre-AndroidX versioning (and will fail in the future for AndroidX)
This adds a new gradle variable googlePlayServicesIidVersion which targets the specific dependency version, and we will only fall back to the existing googlePlayServicesVersion if the IidVersion is not available. So this should fix the issue and still be compatible with the installed base.
While I was in the area I altered our build.gradle style to conform with current react-native-community best practices from react-native-community/discussions-and-proposals#151 (comment) and I committed a new version of example/yarn.lock for current development purposes
Checklist
README.mdCHANGELOG.mdexample/App.js)