Skip to content

Commit

Permalink
refactor(list item): Change keyboardType to textInputKeyboardType
Browse files Browse the repository at this point in the history
Changed keyboardType to match the convention of the other textInput
props

BREAKING CHANGE: keyboardType is now textInputKeyboardType
Closes #804
  • Loading branch information
iRoachie committed Jan 5, 2018
1 parent 3b9ccc3 commit 07e5c9c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/API/lists.md
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ styles = StyleSheet.create({
| textInputAutoCorrect | | boolean | Can tell TextInput to automatically capitalize certain characters. |
| textInputAutoFocus | | boolean | If true, focuses the input on componentDidMount. The default value is false. |
| textInputEditable | | boolean | If false, text is not editable. The default value is true. |
| keyboardType | | string | Can be one of the following: 'default', 'email-address', 'numeric', 'phone-pad', 'ascii-capable', 'numbers-and-punctuation', 'url', 'number-pad', 'name-phone-pad', 'decimal-pad', 'twitter', 'web-search' |
| textInputKeyboardType | | string | Can be one of the following: 'default', 'email-address', 'numeric', 'phone-pad', 'ascii-capable', 'numbers-and-punctuation', 'url', 'number-pad', 'name-phone-pad', 'decimal-pad', 'twitter', 'web-search' |
| textInputMaxLength | | number | Limits the maximum number of characters that can be entered. |
| textInputMultiline | | boolean | If true, the text input can be multiple lines. The default value is false. |
| textInputOnChangeText | | function | Callback that is called when the text input's text changes. Changed text is passed as an argument to the callback handler. |
Expand Down
6 changes: 3 additions & 3 deletions src/list/ListItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const ListItem = props => {
textInputAutoCorrect,
textInputAutoFocus,
textInputEditable,
keyboardType,
textInputKeyboardType,
textInputMaxLength,
textInputMultiline,
textInputOnChangeText,
Expand Down Expand Up @@ -220,7 +220,7 @@ const ListItem = props => {
autoCorrect={textInputAutoCorrect}
autoFocus={textInputAutoFocus}
editable={disabled ? false : textInputEditable}
keyboardType={keyboardType}
keyboardType={textInputKeyboardType}
maxLength={textInputMaxLength}
multiline={textInputMultiline}
onChangeText={textInputOnChangeText}
Expand Down Expand Up @@ -329,7 +329,7 @@ ListItem.propTypes = {
textInputAutoCorrect: PropTypes.bool,
textInputAutoFocus: PropTypes.bool,
textInputEditable: PropTypes.bool,
keyboardType: PropTypes.oneOf([
textInputKeyboardType: PropTypes.oneOf([
'default',
'email-address',
'numeric',
Expand Down

0 comments on commit 07e5c9c

Please sign in to comment.