Skip to content

Commit

Permalink
Fixes failed prop type/style #740 (#763)
Browse files Browse the repository at this point in the history
* Fixes #740

* actually fixed prop
  • Loading branch information
josephch405 authored and xavier-villelegier committed Dec 15, 2017
1 parent f204bef commit 81a629f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 14 deletions.
5 changes: 1 addition & 4 deletions src/tile/Tile.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ const Tile = props => {
backgroundColor: '#ffffff',
flex: 2,
},
imageStyle: {
resizeMode: 'cover',
},
text: {
backgroundColor: 'rgba(0,0,0,0)',
marginBottom: 5,
Expand Down Expand Up @@ -107,7 +104,7 @@ const Tile = props => {
styles.imageContainer,
imageContainerStyle && imageContainerStyle,
]}
imageStyle={styles.imageStyle}
resizeMode="cover"
>
<View
style={[
Expand Down
12 changes: 2 additions & 10 deletions src/tile/__tests__/__snapshots__/Tile.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,7 @@ exports[`Tile component should render tile with icon 1`] = `
}
>
<Image
imageStyle={
Object {
"resizeMode": "cover",
}
}
resizeMode="cover"
source={
Object {
"url": "http://google.com",
Expand Down Expand Up @@ -149,11 +145,7 @@ exports[`Tile component should render without issues 1`] = `
}
>
<Image
imageStyle={
Object {
"resizeMode": "cover",
}
}
resizeMode="cover"
source={
Object {
"url": "http://google.com",
Expand Down

3 comments on commit 81a629f

@yadeleke
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error still occurs. You need to also change ln. 48 in FeaturedTile.js

@xavier-villelegier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadeleke Yep you're right. Feel free to open the PR, or a new issue

@yadeleke
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavier-villelegier this is the first PR i've done. any ideas why I am failing test?
https://github.com/react-native-training/react-native-elements/pull/787

Please sign in to comment.