Skip to content

Commit

Permalink
Failed prop type/style fix (#787)
Browse files Browse the repository at this point in the history
* resizeMode removed from stylesheet

Closes #740

* updated snapshot
  • Loading branch information
yadeleke authored and xavier-villelegier committed Dec 17, 2017
1 parent 1f689f5 commit e4b6aa3
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 55 deletions.
70 changes: 24 additions & 46 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 8 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@
"type": "git",
"url": "git+ssh://git@github.com/dabit3/React-Native-Elements.git"
},
"keywords": ["react-native", "reactjs", "reactnative", "bootstrap"],
"keywords": [
"react-native",
"reactjs",
"reactnative",
"bootstrap"
],
"scripts": {
"build": "rm -rf build; webpack",
"test": "jest",
Expand All @@ -22,11 +27,9 @@
"author": "Nader Dabit & Monte Thakkar",
"license": "MIT",
"bugs": {
"url":
"https://github.com/react-native-training/react-native-elements/issues"
"url": "https://github.com/react-native-training/react-native-elements/issues"
},
"homepage":
"https://github.com/react-native-training/react-native-elements#readme",
"homepage": "https://github.com/react-native-training/react-native-elements#readme",
"collective": {
"type": "opencollective",
"url": "https://opencollective.com/react-native-elements",
Expand Down
2 changes: 1 addition & 1 deletion src/tile/FeaturedTile.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ const FeaturedTile = props => {
imageContainer: {
alignItems: 'center',
justifyContent: 'center',
resizeMode: 'cover',
backgroundColor: '#ffffff',
width,
height,
Expand Down Expand Up @@ -90,6 +89,7 @@ const FeaturedTile = props => {
styles.imageContainer,
imageContainerStyle && imageContainerStyle,
]}
resizeMode = 'cover'
>
<View
style={[
Expand Down
6 changes: 3 additions & 3 deletions src/tile/__tests__/__snapshots__/FeaturedTile.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ exports[`FeaturedTitle component should render with Icon 1`] = `
}
>
<Image
resizeMode="cover"
source={
Object {
"url": "http://google.com",
Expand All @@ -29,7 +30,6 @@ exports[`FeaturedTitle component should render with Icon 1`] = `
"backgroundColor": "#ffffff",
"height": 600,
"justifyContent": "center",
"resizeMode": "cover",
"width": 750,
},
Object {
Expand Down Expand Up @@ -141,6 +141,7 @@ exports[`FeaturedTitle component should render with width and height 1`] = `
width={34}
>
<Image
resizeMode="cover"
source={
Object {
"url": "http://google.com",
Expand All @@ -153,7 +154,6 @@ exports[`FeaturedTitle component should render with width and height 1`] = `
"backgroundColor": "#ffffff",
"height": 20,
"justifyContent": "center",
"resizeMode": "cover",
"width": 34,
},
undefined,
Expand Down Expand Up @@ -242,6 +242,7 @@ exports[`FeaturedTitle component should render without issues 1`] = `
}
>
<Image
resizeMode="cover"
source={
Object {
"url": "http://google.com",
Expand All @@ -254,7 +255,6 @@ exports[`FeaturedTitle component should render without issues 1`] = `
"backgroundColor": "#ffffff",
"height": 600,
"justifyContent": "center",
"resizeMode": "cover",
"width": 750,
},
undefined,
Expand Down

0 comments on commit e4b6aa3

Please sign in to comment.