Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed links and replaces JSX.Element React.ReactElement #1009

Merged
merged 2 commits into from
Mar 17, 2018

Conversation

Gregjarvez
Copy link
Collaborator

fixes #1008

@codecov
Copy link

codecov bot commented Mar 17, 2018

Codecov Report

Merging #1009 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1009   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files          33       33           
  Lines         607      607           
  Branches      113      113           
=======================================
  Hits          334      334           
  Misses        218      218           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827c03f...1d98f97. Read the comment docs.

Copy link
Collaborator

@iRoachie iRoachie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React.ReactElement is a generic, so it accepts another type in its definition.

So it'll be React.ReactElement<{}>

@Gregjarvez
Copy link
Collaborator Author

@iRoachie okay got it

@iRoachie iRoachie merged commit bf85813 into react-native-elements:next Mar 17, 2018
@iRoachie
Copy link
Collaborator

Thanks @Gregjarvez smooth as usual 👌🏽

@Gregjarvez Gregjarvez deleted the ts-definitions branch March 17, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants