Add information about styling ListItems #1915
Conversation
This seems like an important change to me because the writing here doesn't match the images. Adding the example code will _not_ produce the pictured results, because there is no styling in the example code. The code in this comment does produce nice results. See one frustrated user here: https://github.com/react-native-training/react-native-elements/issues/1565#issuecomment-499344338 - we also hit this issue and spent probably a couple hours trying to figure out why styling had died after an upgrade. I believe this issue will be a significant hurdle for new users, and hurts the initial experience quite a lot. It's just not possible to use ListItems without styling (they will look terrible) and this is a library that usually provides at least reasonable styling right away, so at minimum an example seems called for. This PR is one way to do it, ofc more docs could be written as well. Thanks for considering - we use this lib heavily and want it to be a success!
Codecov Report
@@ Coverage Diff @@
## master #1915 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 33 33
Lines 573 573
Branches 73 73
=======================================
Hits 544 544
Misses 25 25
Partials 4 4Continue to review full report at Codecov.
|
|
The issue you linked was referencing upgrading from 0.19.1 to v1.0.0 of the library, in which the styles the author previously added on the list item didn't have the same effect in v1.0.0. The link to the comment you want to add to the docs, will not give the same styling as the images. The images only show what's possible with customization. I think we can add a different message and maybe put it under the Image on the ListItem page. https://react-native-training.github.io/react-native-elements/docs/listitem.html What do you think? |
This seems like an important change to me because the writing here doesn't match the images. Adding the example code will not produce the pictured results, because there is no styling in the example code. The code in this comment does produce nice results.
See one frustrated user here: https://github.com/react-native-training/react-native-elements/issues/1565#issuecomment-499344338 - we also hit this issue and spent probably a couple hours trying to figure out why styling had died after an upgrade.
I believe this issue will be a significant hurdle for new users, and hurts the initial experience quite a lot. It's just not possible to use ListItems without styling (they will look terrible) and this is a library that usually provides at least reasonable styling right away, so at minimum an example seems called for. This PR is one way to do it, ofc more docs could be written as well.
Thanks for considering - we use this lib heavily and want it to be a success!