fix(Button): Improved UX of the LinearGradient button #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingcircle
requested changes
Sep 19, 2020
src/buttons/Button.js
Outdated
| @@ -66,6 +66,16 @@ class Button extends Component { | |||
| ...attributes | |||
| } = this.props; | |||
|
|
|||
| // Refactor to Pressable | |||
| const TouchableComponentInternal = TouchableComponent | |||
There was a problem hiding this comment.
I think this can be changed to:
const TouchableComponentInternal = TouchableComponent ||
Platform.select(...);There was a problem hiding this comment.
@flyingcircle thanks for the feedback :)
flyingcircle
requested changes
Sep 19, 2020
flyingcircle
approved these changes
Sep 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2493
If the button has linear-gradient prop then it will render
TouchableOpacityin Android instead ofTouchableNativeFeedbackin order to provide the user with feedback.Not using
Pressablebecause of the following reasons:@latestversion of React Native, therefore won't be possible for all users to upgrade RN.