Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stack-overflow icon to prop type #2731

Merged
merged 3 commits into from Dec 26, 2020

Conversation

kallefrombosnia
Copy link
Contributor

Removed stack-overflow type from list since it doesnt exists in TypeScript type (SocialMediaType)

Supported types:

image

export type SocialMediaType =
| 'facebook'
| 'twitter'
| 'google-plus-official'
| 'google'
| 'pinterest'
| 'linkedin'
| 'youtube'
| 'vimeo'
| 'tumblr'
| 'instagram'
| 'quora'
| 'flickr'
| 'foursquare'
| 'wordpress'
| 'stumbleupon'
| 'github'
| 'github-alt'
| 'twitch'
| 'medium'
| 'soundcloud'
| 'gitlab'
| 'angellist'
| 'codepen'
| 'weibo'
| 'vk';

Removed stack-overflow type from list since it doesnt exists in TypeScript type (SocialMediaType)

Supported types: 

export type SocialMediaType =
  | 'facebook'
  | 'twitter'
  | 'google-plus-official'
  | 'google'
  | 'pinterest'
  | 'linkedin'
  | 'youtube'
  | 'vimeo'
  | 'tumblr'
  | 'instagram'
  | 'quora'
  | 'flickr'
  | 'foursquare'
  | 'wordpress'
  | 'stumbleupon'
  | 'github'
  | 'github-alt'
  | 'twitch'
  | 'medium'
  | 'soundcloud'
  | 'gitlab'
  | 'angellist'
  | 'codepen'
  | 'weibo'
  | 'vk';
@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #2731 (b839d21) into next (0328937) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2731      +/-   ##
==========================================
- Coverage   93.29%   93.22%   -0.08%     
==========================================
  Files          45       45              
  Lines         761      753       -8     
  Branches       93       92       -1     
==========================================
- Hits          710      702       -8     
  Misses         47       47              
  Partials        4        4              
Impacted Files Coverage Δ
src/buttons/Button.js 100.00% <0.00%> (ø)
src/bottomSheet/BottomSheet.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0328937...b839d21. Read the comment docs.

Copy link
Collaborator

@flyingcircle flyingcircle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stack-overflow is a valid option, so it needs to be added to the type file, not removed from the documentation.

@kallefrombosnia kallefrombosnia changed the title remove stack-overflow icon prop type add stack-overflow icon to prop type Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants