Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change react-native-safe-area-context to a peer #2769

Merged

Conversation

walfly
Copy link
Contributor

@walfly walfly commented Feb 5, 2021

Having multiple versions of the react-native-safe-area-context causes an invariant violation when starting your app. This fixes these two issues #2721 and #2768

I removed react-native-safe-area-context from dependencies and added it to peer and dev depencies.

@flyingcircle
Copy link
Collaborator

I agree this change needs to be made. Can you also change the docs here: https://reactnativeelements.com/docs/#step-3-setup-react-native-safe-area-context so that it reflects this change?

@walfly
Copy link
Contributor Author

walfly commented Feb 5, 2021

Updated

@flyingcircle
Copy link
Collaborator

@walfly thanks! I'll test it out this weekend.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #2769 (de123d3) into next (fca9541) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2769   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files          45       45           
  Lines         755      755           
  Branches       93       93           
=======================================
  Hits          704      704           
  Misses         47       47           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fca9541...9d7f616. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariant Violation: requireNativeComponent: "RNCSafeAreaProvider" was not found in the UIManager.
2 participants