-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change react-native-safe-area-context to a peer #2769
change react-native-safe-area-context to a peer #2769
Conversation
I agree this change needs to be made. Can you also change the docs here: https://reactnativeelements.com/docs/#step-3-setup-react-native-safe-area-context so that it reflects this change? |
Updated |
@walfly thanks! I'll test it out this weekend. |
Codecov Report
@@ Coverage Diff @@
## next #2769 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 45 45
Lines 755 755
Branches 93 93
=======================================
Hits 704 704
Misses 47 47
Partials 4 4 Continue to review full report at Codecov.
|
Having multiple versions of the react-native-safe-area-context causes an invariant violation when starting your app. This fixes these two issues #2721 and #2768
I removed react-native-safe-area-context from dependencies and added it to peer and dev depencies.