-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exported AvatarProps for the issue #2802 #2803
Exported AvatarProps for the issue #2802 #2803
Conversation
Codecov Report
@@ Coverage Diff @@
## next #2803 +/- ##
=======================================
Coverage 90.39% 90.39%
=======================================
Files 47 47
Lines 947 947
Branches 367 367
=======================================
Hits 856 856
Misses 58 58
Partials 33 33 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to export the Prop types, then let's add exports for all of the components. Add exports for all of the components.
src/index.ts
Outdated
@@ -22,6 +22,7 @@ import Image from './image/Image'; | |||
import Card from './card/Card'; | |||
import Tile from './tile/Tile'; | |||
import Avatar from './avatar/Avatar'; | |||
import { AvatarProps } from './avatar/Avatar'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be merged with the line above:
import Avatar, {AvatarProps} from './avatar/Avatar';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Works for me.
@flyingcircle I have made the changes. Could you please review it |
I'm sorry if I wasn't specific enough. I don't want a PR for every single "Props" type to be exported. I want someone to go through all of the components and make sure that the index.ts is exporting all of the "{Component Name}Props" values. Please add that to this PR. |
I have incorporated the necessary changes. Could you please review it |
Exported AvatarProps from index.ts to allow importing AvatarProps from
react-native-elements
instead ofreact-native-elements/dist/avatar/Avatar