Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported AvatarProps for the issue #2802 #2803

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

hetanthakkar
Copy link
Contributor

Exported AvatarProps from index.ts to allow importing AvatarProps from react-native-elements instead of react-native-elements/dist/avatar/Avatar

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #2803 (45508da) into next (08e5136) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2803   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          47       47           
  Lines         947      947           
  Branches      367      367           
=======================================
  Hits          856      856           
  Misses         58       58           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e5136...e5ecf08. Read the comment docs.

@flyingcircle flyingcircle linked an issue Mar 10, 2021 that may be closed by this pull request
Copy link
Collaborator

@flyingcircle flyingcircle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to export the Prop types, then let's add exports for all of the components. Add exports for all of the components.

src/index.ts Outdated
@@ -22,6 +22,7 @@ import Image from './image/Image';
import Card from './card/Card';
import Tile from './tile/Tile';
import Avatar from './avatar/Avatar';
import { AvatarProps } from './avatar/Avatar';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged with the line above:

import Avatar, {AvatarProps} from './avatar/Avatar';

Copy link

@jeeva2812 jeeva2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works for me.

@hetanthakkar
Copy link
Contributor Author

@flyingcircle I have made the changes. Could you please review it

@flyingcircle
Copy link
Collaborator

I'm sorry if I wasn't specific enough. I don't want a PR for every single "Props" type to be exported. I want someone to go through all of the components and make sure that the index.ts is exporting all of the "{Component Name}Props" values. Please add that to this PR.

@hetanthakkar
Copy link
Contributor Author

I have incorporated the necessary changes. Could you please review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export components props types
3 participants